ord: fix a crash when link_design is called twice.#10494
Merged
Conversation
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the linkDesign method in src/OpenRoad.cc to ensure that the link function in verilog_network_ is reset to nullptr after a successful design link. I have no feedback to provide as there were no review comments.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenROAD throws sigsegv when link_design is called twice due to the
sta::VerilogReaderbeing destructed but the openroad object retains the dangling pointer.Repro:
Type of Change
Impact
STA will throw an error instead of crashing.
Verification
./etc/Build.sh).