Skip to content

Remove Boost and OpenMP from ioPlacer#14

Merged
jjcherry56 merged 2 commits into
The-OpenROAD-Project:developfrom
mpfogaca:develop
Dec 8, 2019
Merged

Remove Boost and OpenMP from ioPlacer#14
jjcherry56 merged 2 commits into
The-OpenROAD-Project:developfrom
mpfogaca:develop

Conversation

@mpfogaca
Copy link
Copy Markdown
Contributor

@mpfogaca mpfogaca commented Dec 8, 2019

Remove Boost and OpenMP from ioPlacer

@mpfogaca mpfogaca changed the title Develop Remove Boost and OpenMP from ioPlacer Dec 8, 2019
@jjcherry56 jjcherry56 merged commit 71e7f49 into The-OpenROAD-Project:develop Dec 8, 2019
@jjcherry56
Copy link
Copy Markdown
Contributor

There are still boost references in ioPlacer/include/IOPlacement.h

#include <boost/geometry/geometries/box.hpp>
#include <boost/geometry/geometries/point_xy.hpp>
#include <boost/geometry/geometries/polygon.hpp>

A non-boost/openmp related compile issue is this:

cd /Users/cherry/sta/openroad/build/src/FastRoute && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DDEBUG -I/Users/cherry/sta/openroad/src/FastRoute/include -I/Users/cherry/sta/openroad/src/FastRoute/third_party -I/Users/cherry/sta/openroad/src/FastRoute/third_party/fastroute/include -I/Users/cherry/sta/openroad/src/OpenDB/include -I/Users/cherry/sta/openroad/include -I/Users/cherry/sta/openroad/src/OpenSTA/app -I/Users/cherry/sta/openroad/src/OpenDB/include/opendb -I/Users/cherry/sta/openroad/src/OpenDB/include/lef56 -I/Users/cherry/sta/openroad/src/OpenDB/src/lef56/lef -I/Users/cherry/sta/openroad/src/FastRoute/third_party/fastroute/../flute -I/Users/cherry/sta/openroad/src/flute3 -isystem /usr/local/include -g -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -std=c++11 -o CMakeFiles/FastRoute.dir/src/DBWrapper.cpp.o -c /Users/cherry/sta/openroad/src/FastRoute/src/DBWrapper.cpp
In file included from /Users/cherry/sta/openroad/src/FastRoute/src/DBWrapper.cpp:1:
In file included from /Users/cherry/sta/openroad/src/FastRoute/src/DBWrapper.h:43:
In file included from /Users/cherry/sta/openroad/src/FastRoute/src/Netlist.h:49:
/Users/cherry/sta/openroad/src/FastRoute/src/Pin.h:41:10: fatal error: 'bits/stdc++.h'
file not found
#include <bits/stdc++.h>
^~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [src/FastRoute/CMakeFiles/FastRoute.dir/src/DBWrapper.cpp.o] Error 1
make[1]: *** [src/FastRoute/CMakeFiles/FastRoute.dir/all] Error 2
make: *** [all] Error 2

This should the appropriate standard headers, not a gcc implementation specific "include the kitchen sink" header. See https://stackoverflow.com/questions/31816095/why-should-i-not-include-bits-stdc-h

@jjcherry56
Copy link
Copy Markdown
Contributor

Another problem is that src/TclInterfaceWrap.cpp is in the sources, which marks the submodule as dirty. One solution is to add it to .gitignore, but the better solution is to not insert derived files into the sources. The CMakeLists.txt file in openroad (or on the add_tool branch) illustrates how to do this for the swig output file.

@mpfogaca
Copy link
Copy Markdown
Contributor Author

mpfogaca commented Dec 9, 2019

Hi, @jjcherry56

Please check this new pull request:
#15

Att,
--Mateus

tspyrou pushed a commit that referenced this pull request Sep 10, 2020
…_row_detection

Opendp multi row detection
gudeh pushed a commit to gudeh/OpenROAD that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants