Skip to content

Add OpenPhySyn#17

Closed
ahmed-agiza wants to merge 24 commits into
developfrom
add-openphysyn
Closed

Add OpenPhySyn#17
ahmed-agiza wants to merge 24 commits into
developfrom
add-openphysyn

Conversation

@ahmed-agiza
Copy link
Copy Markdown
Contributor

@ahmed-agiza ahmed-agiza commented Dec 10, 2019

  • Integrated OpenPhySyn.
  • Did some updates to the Dockerfile:
    • Updated GCC to 7.3.0.
    • Updated SWIG to 4.0.1

@ahmed-agiza ahmed-agiza reopened this Dec 10, 2019
@ahmed-agiza ahmed-agiza requested a review from tspyrou December 10, 2019 05:45
@tspyrou tspyrou requested a review from jjcherry56 December 10, 2019 15:16
@tspyrou
Copy link
Copy Markdown
Contributor

tspyrou commented Dec 11, 2019

Hi Ahmed,
We don't want end users to have to install boost. Instead if you absolutely need a package, add the code to your submodule and build it there. That way we won't require all of boost to be installed by everyone when we use a small piece or require end users to install boost.

@ahmed-agiza
Copy link
Copy Markdown
Contributor Author

No problem, I can ditch Boost.

@ahmed-agiza
Copy link
Copy Markdown
Contributor Author

@tspyrou Boost has been removed.
@jjcherry56 Do you have any advice with or against explicitly using SWIG 4.0 in the Dockerfile rather than leaving the default one in the image (2.0)?

@jjcherry56
Copy link
Copy Markdown
Contributor

jjcherry56 commented Dec 11, 2019 via email

@ahmed-agiza
Copy link
Copy Markdown
Contributor Author

ahmed-agiza commented Dec 11, 2019

The tool compiles fine with SWIG 3.0, I just upgraded it to 4.0 to reduce the gap for future updates.

@abdelrahmanhosny
Copy link
Copy Markdown
Contributor

Please, re-write the Dockerfile. It has a total size of 9+GB which constantly blows up disk space usage.
openroad/openroad latest 13872ee18d6e 27 hours ago 9.35GB

Each container spawned from this image is takes that much space. The original Dockerfile has less than 2GB of disk space
openroad/openroad base 001b7e2af995 5 days ago 1.98GB

Also, for this specific repo, can you add --rm to every docker run in test.sh? This will prevent the containers from just being there.

Thanks

@tspyrou tspyrou closed this Dec 13, 2019
gudeh pushed a commit to gudeh/OpenROAD that referenced this pull request Sep 29, 2025
openroad-ci pushed a commit to The-OpenROAD-Project-staging/OpenROAD that referenced this pull request Apr 22, 2026
Previous build The-OpenROAD-Project#17 on 506b437 succeeded but build The-OpenROAD-Project#20
errored with 'This commit cannot be built' after force-push
churn. Empty commit to retrigger clean build.

Signed-off-by: minjukim55 <mkim@precisioninno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants