drt: fix off-grid violations on first iterations#2033
Merged
eder-matheus merged 3 commits intoJul 6, 2022
Merged
Conversation
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
maliberty
reviewed
Jul 6, 2022
| xLoc = *(xLocs.begin()); | ||
| } else { | ||
| xLoc = (xl(pinRect) + xh(pinRect)) / 2; | ||
| frCoord manuGrid = getTech()->getManufacturingGrid(); |
Member
There was a problem hiding this comment.
There look to be two similar blocks in the frcBTerm section below.
Member
There was a problem hiding this comment.
If you are going to have four copies of this it might be time to factor it into a helper function.
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
Signed-off-by: Eder Monteiro <eder.matheus.monteiro@gmail.com>
maliberty
approved these changes
Jul 6, 2022
openroad-robot
pushed a commit
to The-OpenROAD-Project-staging/OpenROAD
that referenced
this pull request
Apr 16, 2024
…t-private/master get all the latest commits from the master branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eder Monteiro eder.matheus.monteiro@gmail.com