Skip to content

odb: add support for LEF58_AREA property#2267

Merged
eder-matheus merged 16 commits into
The-OpenROAD-Project:masterfrom
eder-matheus:odb_area
Sep 15, 2022
Merged

odb: add support for LEF58_AREA property#2267
eder-matheus merged 16 commits into
The-OpenROAD-Project:masterfrom
eder-matheus:odb_area

Conversation

@eder-matheus
Copy link
Copy Markdown
Member

@eder-matheus eder-matheus commented Sep 13, 2022

No description provided.

@eder-matheus
odb: add dbAreaRule data structures
a577e9e 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: update dbTechLayerAreaRule with functions needed for the parser
81c5132 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb:: add parser for LEF58_AREA
df8fcad 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: call LEF58_AREA parser on lefin.cpp
132ab49 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: add cpp tests for PROPERTY LEF58_AREA
07b4783 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: update schema version
6bea861 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: update design.odb
55aca3a 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus eder-matheus requested review from maliberty and osamahammad21 and removed request for maliberty September 13, 2022 23:17
gadfort
gadfort requested changes Sep 14, 2022
View reviewed changes
Comment thread src/odb/src/db/dbTechLayerAreaRule.cpp Outdated
Comment thread src/odb/src/db/dbTechLayerAreaRule.cpp Outdated
osamahammad21
osamahammad21 requested changes Sep 14, 2022
View reviewed changes
Comment thread src/odb/include/odb/db.h Outdated
Comment thread src/odb/src/codeGenerator/dbTechLayerAreaRule.json
Comment thread src/odb/src/db/dbTechLayerAreaRule.cpp Outdated
Comment thread src/odb/src/db/dbTechLayerAreaRule.cpp Outdated
Comment thread src/odb/src/db/dbTechLayerAreaRule.h Outdated
Comment thread src/odb/src/lefin/lefTechLayerAreaRuleParser.cpp Outdated
Comment thread src/odb/src/lefin/lefTechLayerAreaRuleParser.cpp Outdated
Comment thread src/odb/src/lefin/lefTechLayerAreaRuleParser.cpp Outdated
Comment thread src/odb/src/codeGenerator/dbTechLayerAreaRule.json Outdated
@eder-matheus
odb: fix typo
1618e00 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: move user defined funcs to properly section
ee98b55 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: fix typo (again)
4ef19a2 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: add trailing to the end of class field names
ca627e6 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: small fixes
7a7ee7c 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: use 2 bits for overlap instead of int
2f0cb88 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: use int for mask and overlap and remove setNumber
fc7d8a9 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
odb: update tests
a268673 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@maliberty
Copy link
Copy Markdown
Member

maliberty commented Sep 14, 2022

Has this been through secure-CI?

@maliberty
Copy link
Copy Markdown
Member

maliberty commented Sep 14, 2022

Is src/odb/test/data/design.odb necessary? The next time the schema changes this test will break. It would be better to use lef/def for stability of the test.

@eder-matheus
Copy link
Copy Markdown
Member Author

eder-matheus commented Sep 14, 2022 •
edited
Loading

Has this been through secure-CI?

I started a run yesterday, and I saw a few metrics failures. I've started another run now.

maliberty
maliberty reviewed Sep 14, 2022
View reviewed changes
Comment thread src/odb/src/lefin/lefTechLayerAreaRuleParser.cpp Outdated
@eder-matheus
odb: use snake case for var names
13f5a14 
Signed-off-by: Eder Monteiro <emrmonteiro@inf.ufrgs.br>
@eder-matheus
Copy link
Copy Markdown
Member Author

eder-matheus commented Sep 14, 2022

Is src/odb/test/data/design.odb necessary? The next time the schema changes this test will break. It would be better to use lef/def for stability of the test.

We already have lef/def tests in the unit tests. To update the read_db test, should I read lef/def, write an odb file and then read the generated odb? Is there a way to "unload" a design using the openroad cmds?

@maliberty
Copy link
Copy Markdown
Member

maliberty commented Sep 14, 2022

Is src/odb/test/data/design.odb necessary? The next time the schema changes this test will break. It would be better to use lef/def for stability of the test.

We already have lef/def tests in the unit tests. To update the read_db test, should I read lef/def, write an odb file and then read the generated odb? Is there a way to "unload" a design using the openroad cmds?

Never mind I see this is the schema version test which is the only one that uses an odb.

@eder-matheus
Copy link
Copy Markdown
Member Author

eder-matheus commented Sep 15, 2022

@maliberty My secure-ci run finished with two metric errors in the private designs (gf12 ariane and gf12 swerv wrapper). Not sure if my changes cause it.

@osamahammad21
Copy link
Copy Markdown
Member

osamahammad21 commented Sep 15, 2022

My secure-ci run finished with two metric errors in the private designs (gf12 ariane and gf12 swerv wrapper). Not sure if my changes cause it.

@vvbandeira are those tests failing on master?

@osamahammad21 osamahammad21 mentioned this pull request Sep 15, 2022
Open
@vvbandeira
Copy link
Copy Markdown
Member

vvbandeira commented Sep 15, 2022

My secure-ci run finished with two metric errors in the private designs (gf12 ariane and gf12 swerv wrapper). Not sure if my changes cause it.

@vvbandeira are those tests failing on master?

Yes, you can consider secure ci as passing.

@osamahammad21
Copy link
Copy Markdown
Member

osamahammad21 commented Sep 15, 2022 •
edited
Loading

@arlpetergadfort I've confirmed your requested changes are addressed. Can you please approve PR if no other changes are needed.

@eder-matheus eder-matheus merged commit b763145 into The-OpenROAD-Project:master Sep 15, 2022
@eder-matheus eder-matheus deleted the odb_area branch September 15, 2022 18:20
@proppy proppy mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadfort gadfort gadfort approved these changes

@osamahammad21 osamahammad21 osamahammad21 approved these changes

@maliberty maliberty Awaiting requested review from maliberty

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eder-matheus @maliberty @osamahammad21 @vvbandeira @gadfort