src: handle -python with no args#2389
Merged
Merged
Conversation
proppy
force-pushed
the
fix-python-noargs
branch
from
6e9808d to
34901e8
Compare
Signed-off-by: Johan Euphrosine <proppy@google.com>
proppy
force-pushed
the
fix-python-noargs
branch
from
34901e8 to
5f11ae6
Compare
maliberty
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2375
As commented in #2375 (comment),
openroad -pythonnow prints a warning when called without argument.This PR makes sure that we don't attempt to open a file if no arguments is provided after
-python.Note: I also noticed that the
findCmd*helpers instadon't seems to discard singular argument (i.e: don't replace-pythonwith\0if it's the last argument), see The-OpenROAD-Project/OpenSTA#126.