Builds new library structure for OpenROAD modules#2848
Merged
Conversation
QuantamHD
force-pushed
the
new_world_order
branch
from
dda7b59 to
66f2261
Compare
Collaborator
Author
QuantamHD
force-pushed
the
new_world_order
branch
2 times, most recently
from
dfed308 to
2a0a8a7
Compare
Member
|
fyi CI is failing at pr-head because is missing #2841 |
Member
|
compostable :) |
maliberty
reviewed
Feb 4, 2023
Collaborator
Author
Thanks 👍. Didn't mean...
|
QuantamHD
force-pushed
the
new_world_order
branch
2 times, most recently
from
939f588 to
6d2ab76
Compare
The new library ordering of modules decouples the TCL/Wrapper code from the underlying module code. This allows us to create unit tests for each module without having to link the entire application and swig layers. It should lead to a more compostable environment. And now a poem, because I like being extra. ``` The path is dark and cold, The trees are gnarled and old, The sun is hidden from my sight, And I am lost in endless night. I stumble on, I know not where, My only guide is my despair. The path is hard and the journey long, And I am weak, I cannot go on. But then I see a light, A glimmer of hope in the night. I run towards it, I must find it, It is my only chance to be free. I stumble out into the light, And I see that I have died. I am in a new world, A world of peace and light. I am free. ``` Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
QuantamHD
force-pushed
the
new_world_order
branch
from
6d2ab76 to
f4a65c5
Compare
Signed-off-by: Ethan Mahintorabi <ethanmoon@google.com>
maliberty
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new library ordering of modules decouples the TCL/Wrapper code from the underlying module code. This allows us to create unit tests for each module without having to link the entire application and swig layers.
It should lead to a more
compostablecomposable environment.And now a poem, because I like being extra.
Signed-off-by: Ethan Mahintorabi ethanmoon@google.com