rsz: ensure rsz resets buffer_cells_ when dont_use_ changes to force …#3491
Merged
Merged
Conversation
…it to find buffers again ensuring it honors the dont_use changes Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| dont_use_.insert(cell); | ||
| else | ||
| dont_use_.erase(cell); | ||
|
|
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [google-readability-braces-around-statements]
Suggested change
| if (dont_use) { |
src/rsz/src/Resizer.cc:1273:
- else
+ } else
Comment on lines
+1274
to
+1275
| buffer_cells_.clear(); | ||
| buffer_lowest_drive_ = nullptr; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [google-readability-braces-around-statements]
Suggested change
| buffer_cells_.clear(); | |
| buffer_lowest_drive_ = nullptr; | |
| else { | |
| dont_use_.erase(cell); | |
| } |
maliberty
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…it to find buffers again ensuring it honors the dont_use changes
Fixes:
dont_usethat happen to overlap with thebuffer_cells_didn't ensure it selected those cells after they were unset.