Skip to content

etc: Remove redundant definition.#5865

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
titan73:master
Oct 4, 2024
Merged

etc: Remove redundant definition.#5865
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
titan73:master

Conversation

@titan73
Copy link
Copy Markdown
Contributor

@titan73 titan73 commented Oct 3, 2024

It is a left over from 4fef3cb which moved definition few lines above.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@titan73
Copy link
Copy Markdown
Contributor Author

titan73 commented Oct 3, 2024

Seems something's wrong with the CI:

#8 131.3 Cloning into 'eigen'...
#8 131.8 error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502
#8 131.8 fatal: error reading section header 'shallow-info'
#8 ERROR: process "/bin/sh -c /tmp/DependencyInstaller.sh -common $INSTALLER_ARGS" did not complete successfully: exit code: 128

[4/6] RUN /tmp/DependencyInstaller.sh -common -save-deps-prefixes=/etc/openroad_deps_prefixes.txt -eqy -ci:
131.1 gcc.archive bin.v2/libs/test/build/gcc-11/release/link-static/threading-multi/visibility-hidden/libboost_test_exec_monitor.a
131.1 boost-install.generate-cmake-variant- bin.v2/libs/test/build/gcc-11/release/link-static/threading-multi/visibility-hidden/libboost_test_exec_monitor-variant-static.cmake
131.1 boost-install.generate-cmake-variant- bin.v2/libs/test/build/gcc-11/release/threading-multi/visibility-hidden/libboost_test_exec_monitor-variant-shared.cmake
131.1 common.copy /usr/local/lib/cmake/boost_test_exec_monitor-1.80.0/libboost_test_exec_monitor-variant-static.cmake
131.1 common.copy /usr/local/lib/libboost_test_exec_monitor.a
131.1 common.copy /usr/local/lib/cmake/boost_test_exec_monitor-1.80.0/libboost_test_exec_monitor-variant-shared.cmake
131.3 ...updated 16770 targets...
131.3 Cloning into 'eigen'...
131.8 error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502
131.8 fatal: error reading section header 'shallow-info'


Dockerfile.dev:17

15 |
16 | RUN /tmp/DependencyInstaller.sh -base
17 | >>> RUN /tmp/DependencyInstaller.sh -common $INSTALLER_ARGS
18 |
19 | RUN echo "$fromImage" | grep -q "ubuntu" && \

ERROR: failed to solve: process "/bin/sh -c /tmp/DependencyInstaller.sh -common $INSTALLER_ARGS" did not complete successfully: exit code: 128
script returned exit code 1

@maliberty
Copy link
Copy Markdown
Member

Looks like eigen server timed out so I've re-triggered the build. The change looks trivial enough it should go through.

@maliberty maliberty enabled auto-merge October 3, 2024 14:09
@titan73
Copy link
Copy Markdown
Contributor Author

titan73 commented Oct 4, 2024

It seems there was a timeout issue:

Cancelling nested steps due to timeout
[Pipeline] // node
[Pipeline] // node
[Pipeline] }
Failed in branch Flow Test - aes_sky130hs
[Pipeline] }
Failed in branch Flow Test - ibex_sky130hs
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Failed in branch Build and Test
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // timeout
[Pipeline] End of Pipeline
Timeout has been exceeded
org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 389c9c17-86de-4e29-9b97-69b6e371a0af

GitHub has been notified of this commit’s build result

Finished: ABORTED

It is a left over from 4fef3cb which
moved definition few lines above.

Signed-off-by: Christian Costa <titan.costa@gmail.com>
auto-merge was automatically disabled October 4, 2024 20:05

Head branch was pushed to by a user without write access

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@titan73
Copy link
Copy Markdown
Contributor Author

titan73 commented Oct 4, 2024

Retriggered tests. They pass now. Auto-merging has been disabled when pushing from rebase.

@maliberty maliberty merged commit 82140a0 into The-OpenROAD-Project:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants