Skip to content

[DO NOT REVIEW] orfs: bump, fix invalid start points for paths#7722

Closed
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
Pinata-Consulting:orfs-sdc-fix-illegal-start-point
Closed

[DO NOT REVIEW] orfs: bump, fix invalid start points for paths#7722
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
Pinata-Consulting:orfs-sdc-fix-illegal-start-point

Conversation

@oharboe
Copy link
Copy Markdown
Collaborator

@oharboe oharboe commented Jul 4, 2025

No description provided.

@oharboe oharboe requested a review from maliberty July 4, 2025 21:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2025

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 5, 2025

Weird, passed locally. I'm merging with master and pushing again in case I'm confused...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2025

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 5, 2025

@maliberty Any ideas?

On the server pr-head, I get:

[ERROR] finish__timing__setup__ws fail test: -398.247 >= -351.15

Locally:

$ bazelisk build -c opt test/orfs/mock-array:MockArray_generate_metadata
[deleted]
Target //test/orfs/mock-array:MockArray_generate_metadata up-to-date:
  bazel-bin/test/orfs/mock-array/reports/asap7/MockArray/base/metadata.json
[deleted]

In bazel-bin/test/orfs/mock-array/reports/asap7/MockArray/base/metadata.json, I see:

  "finish__timing__setup__ws": -338.653,

How can the result be different locally and on the server?

Inconceivable!

To find out where it diverges, I'd need to have the logs from the server. I would have preferred an early failure in Bazel and that archives were made available immediately, in this case, now I have to wait for all other tests to run(so 2 hours).

$ bazelisk build -c opt test/orfs/mock-array:MockArray_final
$ grep __ws bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/*.json
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/2_1_floorplan.json:	"floorplan__timing__setup__ws": 14.8951,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/2_1_floorplan.json:	"floorplan__timing__hold__ws": 59.6762,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_3_place_gp.json:	"globalplace__timing__setup__ws": 69.726,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_3_place_gp.json:	"globalplace__timing__hold__ws": 60.402,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_4_place_resized.json:	"placeopt__timing__setup__ws": 2.72594,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_4_place_resized.json:	"placeopt__timing__hold__ws": 60.402,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_5_place_dp.json:	"detailedplace__timing__setup__ws": 2.96368,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_5_place_dp.json:	"detailedplace__timing__hold__ws": 60.0538,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/4_1_cts.json:	"cts__timing__setup__ws": -578.934,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/4_1_cts.json:	"cts__timing__hold__ws": -45.2844,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/5_1_grt.json:	"globalroute__timing__setup__ws": -400.333,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/5_1_grt.json:	"globalroute__timing__hold__ws": -22.864,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/6_report.json:	"finish__timing__setup__ws": -338.653,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/6_report.json:	"finish__timing__hold__ws": -8.19103,

Tried on my workstation instead of my laptop, it has many more cores:

$ git checkout pinata/orfs-sdc-fix-illegal-start-point
$ grep __ws bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/*.json
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/2_1_floorplan.json:	"floorplan__timing__setup__ws": 14.8951,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/2_1_floorplan.json:	"floorplan__timing__hold__ws": 59.6762,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_3_place_gp.json:	"globalplace__timing__setup__ws": 69.726,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_3_place_gp.json:	"globalplace__timing__hold__ws": 60.402,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_4_place_resized.json:	"placeopt__timing__setup__ws": 2.72594,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_4_place_resized.json:	"placeopt__timing__hold__ws": 60.402,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_5_place_dp.json:	"detailedplace__timing__setup__ws": 2.96368,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/3_5_place_dp.json:	"detailedplace__timing__hold__ws": 60.0538,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/4_1_cts.json:	"cts__timing__setup__ws": -578.934,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/4_1_cts.json:	"cts__timing__hold__ws": -45.2844,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/5_1_grt.json:	"globalroute__timing__setup__ws": -400.333,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/5_1_grt.json:	"globalroute__timing__hold__ws": -22.864,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/6_report.json:	"finish__timing__setup__ws": -338.653,
bazel-bin/test/orfs/mock-array/logs/asap7/MockArray/base/6_report.json:	"finish__timing__hold__ws": -8.19103,

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 5, 2025

Hmm.... still passes....

$ bazelisk test --host_cxxopt=-stdlib=libstdc++ --host_linkopt=-lstdc++ --host_compilation_mode=dbg --curses=no --force_pic test/orfs/mock-array:MockArray_test
[deleted]
//test/orfs/mock-array:MockArray_test                                    PASSED in 0.3s

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 6, 2025

@vvbandeira Could you provide the logs for the failing tests? Thanks!

@vvbandeira vvbandeira mentioned this pull request Jul 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 7, 2025

@maliberty Need some better tools to chase down the divergence in results The-OpenROAD-Project/OpenROAD-flow-scripts#3294

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

@oharboe oharboe changed the title orfs: bump, fix invalid start points for paths [DO NOT REVIEW] orfs: bump, fix invalid start points for paths Jul 7, 2025
@oharboe oharboe force-pushed the orfs-sdc-fix-illegal-start-point branch from 777bcee to 3a53bd9 Compare July 8, 2025 06:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe force-pushed the orfs-sdc-fix-illegal-start-point branch from 3a53bd9 to 6326324 Compare July 8, 2025 06:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Copy Markdown
Collaborator Author

oharboe commented Jul 8, 2025

@maliberty @gadfort Closing this PR to keep it unchanged as it is part of the information that goes into #7746

@oharboe oharboe closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants