Fix a couple of dependency and linking issues#7728
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Once #7730 merges, please merge master to this PR so we can see bazel run |
There was a problem hiding this comment.
Why is this necessary? mpl has no direct use of cudd
There was a problem hiding this comment.
ah, it was not. It was due to an include of "util.h" which is a very generically named header without the use of project-relative paths. And it is also provided by cudd. Anyway, my scripts picked up on that.
We really should establish project-relative paths soon.
Fixed.
There was a problem hiding this comment.
I don't see it as fixed. I see the same in rcx as well.
hzeller
force-pushed
the
feature-20250706-fix-link
branch
from
f3d5710 to
9ff89ce
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@hzeller I think a merge with master will fix the bazelisk snag. |
hzeller
force-pushed
the
feature-20250706-fix-link
branch
from
dff45e4 to
2fcda33
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Bazelisk is fixed but it now fails on build errors, eg |
hzeller
force-pushed
the
feature-20250706-fix-link
branch
from
1e7d2e2 to
e56fb30
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
The ompt-specific.cpp file is included in ompt-general.cpp, so it should not be also compiled and linked separately, otherwise this results in duplicate symbols in linking. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
The unit test fails to link as rsz can not have its needed dependency on grt (e.g. rsz::Resizer::ensureParasitics() calls grt::GlobalRouter::haveRoutes()) Since we can't provide a proper dependency quite yet, add it to the unittest to satisfy. Signed-off-by: Henner Zeller <hzeller@google.com>
hzeller
force-pushed
the
feature-20250706-fix-link
branch
from
e56fb30 to
efc2353
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
No description provided.