Skip to content

rsz: Fixed incorrect (dbNet*)staToDb() call to dbModNet*.#7942

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-jhkim-rsz-modnet-fix
Aug 2, 2025
Merged

rsz: Fixed incorrect (dbNet*)staToDb() call to dbModNet*.#7942
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-jhkim-rsz-modnet-fix

Conversation

@openroad-ci
Copy link
Copy Markdown
Collaborator

@openroad-ci openroad-ci commented Aug 2, 2025

Problem

Multiple RSZ regression fail.

        234 - rsz.gain_buffering1_hier.tcl (Failed)             IntegrationTest tcl rsz log_compare
        237 - rsz.repair_fanout3_hier.tcl (Failed)              IntegrationTest tcl rsz log_compare
        249 - rsz.clone_hier.tcl (Failed)                       IntegrationTest tcl rsz log_compare
        267 - rsz.pinswap_hier.tcl (Failed)                     IntegrationTest tcl rsz log_compare
        292 - rsz.repair_hold1_hier.tcl (Failed)                IntegrationTest tcl rsz log_compare
        314 - rsz.repair_setup4_hier.tcl (Failed)               IntegrationTest tcl rsz log_compare
        382 - rsz.split_load_hier.tcl (Failed)

Root cause

Missing dbModNet handling caused assert fail in staToDb(const Net*).

Fix

Used staToDb(const Net*, dbNet*&, dbModNet*&) API instead of stdToDb(const Net*).

Etc

  • Added debug log in early sizing stage.

@jhkim-pii
rsz: Fixed incorrect (dbNet*)staToDb() call to dbModNet*.
a3f4cff 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

jhkim-pii
jhkim-pii reviewed Aug 2, 2025
View reviewed changes
Comment thread src/rsz/src/RepairDesign.cc

odb::dbNet* net_db = nullptr;
odb::dbModNet* mod_net_db = nullptr;
db_network_->staToDb(net, net_db, mod_net_db);
Copy link
Copy Markdown
Contributor

@jhkim-pii jhkim-pii Aug 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix 1

jhkim-pii
jhkim-pii reviewed Aug 2, 2025
View reviewed changes
Comment thread src/rsz/src/Resizer.cc
dbNet* db_net = db_network_->staToDb(net);
odb::dbNet* db_net = nullptr;
odb::dbModNet* db_mod_net = nullptr;
db_network_->staToDb(net, db_net, db_mod_net);
Copy link
Copy Markdown
Contributor

@jhkim-pii jhkim-pii Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix 2

@jhkim-pii jhkim-pii requested review from maliberty and povik August 2, 2025 15:21
@maliberty maliberty enabled auto-merge August 2, 2025 15:42
@maliberty maliberty merged commit 3a358b5 into The-OpenROAD-Project:master Aug 2, 2025
11 checks passed
@maliberty maliberty deleted the secure-jhkim-rsz-modnet-fix branch August 2, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhkim-pii jhkim-pii jhkim-pii left review comments

@maliberty maliberty maliberty approved these changes

@povik povik Awaiting requested review from povik

Assignees

@jhkim-pii jhkim-pii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openroad-ci @maliberty @jhkim-pii