sdc: add clockGroupsNameMap#352
Merged
maliberty merged 1 commit intoApr 23, 2026
Merged
Conversation
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new public getter, clockGroupsNameMap, to the Sdc class in include/sta/Sdc.hh. The review feedback recommends defining this getter on a single line to align with the established coding style for simple inline getters within the same class.
Comment on lines
+1039
to
+1042
| const ClockGroupsNameMap &clockGroupsNameMap() const | ||
| { | ||
| return clk_groups_name_map_; | ||
| } |
There was a problem hiding this comment.
This getter should be defined on a single line to maintain consistency with the existing style for simple inline getters in this class, such as exceptions(), groupPaths(), and clocks().
const ClockGroupsNameMap &clockGroupsNameMap() const { return clk_groups_name_map_; }
maliberty
approved these changes
Apr 23, 2026
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
maliberty
force-pushed
the
add-clock_group_map
branch
from
992b285 to
6bb54f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds access
clk_groups_name_map_.