Revert driver-vertex levelization (PR #327): move to OpenROAD/dbSta#358
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request removes the levelizedDrvrVertices functionality and its associated reporting tools and regression tests from the codebase. This includes cleaning up the Sta and Levelize classes by removing the relevant methods and member variables. I have no feedback to provide.
precisionmoon
left a comment
There was a problem hiding this comment.
Thank you for taking care of this.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Reverts the driver-vertex levelization additions from PR #327 (commit 94bb37b). Functionality moves to OpenROAD's
src/dbSta/to keep this fork bit-for-bit compatible with upstreamparallaxsw/OpenSTAand unblock building OpenROAD against upstream.Background
PR #327 added
Sta::levelizedDrvrVertices()+Levelize::levelizedDrvrVertices()cache +report_levelized_drvr_verticesTcl helper. These don't exist upstream. OpenROAD'srsz/callssta_->levelizedDrvrVertices()(wheresta_issta::dbSta*), so building OpenROAD against upstream OpenSTA fails:error: no member named 'levelizedDrvrVertices' in 'sta::Sta'
The companion OpenROAD PR https://github.com/The-OpenROAD-Project-private/OpenROAD/pull/3400 moves the implementation into
dbStausing only public OpenSTA APIs (StaState::levelize(),LevelizeObserver), so existing rsz call sites resolve via inheritance (dbSta : public Sta) without source changes.Changes
include/sta/Sta.hh— droplevelizedDrvrVertices()declsearch/Sta.cc— drop implsearch/Levelize.{hh,cc}— drop public API, protected helper, cache members + invalidation inclear/invalid/deleteVertexBefore/relevelizeFrom/deleteEdgeBeforegraph/Graph.i— dropreport_levelized_drvr_verticesTcl helper +search/Levelize.hhincludetest/regression_vars.tcl— droplevelized_drvr_vertices1entrytest/levelize_drvr_vertices1.{tcl,ok},test/gcd_asap7.v— removed (relocated to OpenROADdbSta/test/)