Skip to content

Revert driver-vertex levelization (PR #327): move to OpenROAD/dbSta#358

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sta_move_drvr_level_to_dbsta
May 10, 2026
Merged

Revert driver-vertex levelization (PR #327): move to OpenROAD/dbSta#358
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:sta_move_drvr_level_to_dbsta

Conversation

@openroad-ci
Copy link
Copy Markdown
Collaborator

Summary

Reverts the driver-vertex levelization additions from PR #327 (commit 94bb37b). Functionality moves to OpenROAD's src/dbSta/ to keep this fork bit-for-bit compatible with upstream parallaxsw/OpenSTA and unblock building OpenROAD against upstream.

Background

PR #327 added Sta::levelizedDrvrVertices() + Levelize::levelizedDrvrVertices() cache + report_levelized_drvr_vertices Tcl helper. These don't exist upstream. OpenROAD's rsz/ calls
sta_->levelizedDrvrVertices() (where sta_ is sta::dbSta*), so building OpenROAD against upstream OpenSTA fails:
error: no member named 'levelizedDrvrVertices' in 'sta::Sta'

The companion OpenROAD PR https://github.com/The-OpenROAD-Project-private/OpenROAD/pull/3400 moves the implementation into dbSta using only public OpenSTA APIs (StaState::levelize(), LevelizeObserver), so existing rsz call sites resolve via inheritance (dbSta : public Sta) without source changes.

Changes

  • include/sta/Sta.hh — drop levelizedDrvrVertices() decl
  • search/Sta.cc — drop impl
  • search/Levelize.{hh,cc} — drop public API, protected helper, cache members + invalidation in clear/invalid/deleteVertexBefore/relevelizeFrom/deleteEdgeBefore
  • graph/Graph.i — drop report_levelized_drvr_vertices Tcl helper + search/Levelize.hh include
  • test/regression_vars.tcl — drop levelized_drvr_vertices1 entry
  • test/levelize_drvr_vertices1.{tcl,ok}, test/gcd_asap7.v — removed (relocated to OpenROAD dbSta/test/)

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the levelizedDrvrVertices functionality and its associated reporting tools and regression tests from the codebase. This includes cleaning up the Sta and Levelize classes by removing the relevant methods and member variables. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@precisionmoon precisionmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.

@maliberty
Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@maliberty maliberty merged commit 19a2f3a into The-OpenROAD-Project:master May 10, 2026
6 of 7 checks passed
@openroad-ci openroad-ci deleted the sta_move_drvr_level_to_dbsta branch May 10, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants