capitalize

[mohammadreza490]

Capitalization of the first character of a word or a sentence. It works like the capitalize() method of the strings in Python

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6a13a0a0-ed71-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 44f0ae20-ed72-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ed65c340-ed74-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c76f5420-ed75-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f8fc9200-ed75-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dd967390-ed76-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9e475eb0-ed77-11ea-b6ba-27fe84eba218

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 35c1c050-ed78-11ea-b6ba-27fe84eba218

[TravisBuddy]

Travis tests have failed

Hey @mohammadreza490,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 86e10120-ed79-11ea-b6ba-27fe84eba218

[TravisBuddy]

Travis tests have failed

Hey @mohammadreza490,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c0864740-ed7a-11ea-b6ba-27fe84eba218

[TravisBuddy]

Travis tests have failed

Hey @mohammadreza490,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dfb51b90-ed7b-11ea-a128-157d03751755

[TravisBuddy]

Travis tests have failed

Hey @mohammadreza490,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d7809fc0-ed7c-11ea-a128-157d03751755

[cclauss]

@mohammadreza490 Thanks for your submission but in its current form it is just a demonstration of how-to-use the builtin str.capitalize() method. This repo focuses on building new algorithms, not on how-to-use existing ones.

So here is an alternative approach to consider... Make a dict with the keys being string.ascii_lowercase and the values being string.ascii_uppercase. You could then use that dict to capitalize the first letter (if that letter is a key in the dict) without needing to use str.capitalize().

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 38f86760-edd2-11ea-a128-157d03751755

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8ecec7a0-edd3-11ea-a128-157d03751755

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1f0c2240-edd4-11ea-a128-157d03751755

[TravisBuddy]

Hey @mohammadreza490,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 315c2200-edd5-11ea-a128-157d03751755

[mohammadreza490]

@mohammadreza490 Thanks for your submission but in its current form it is just a demonstration of how-to-use the builtin str.capitalize() method. This repo focuses on building new algorithms, not on how-to-use existing ones.

So here is an alternative approach to consider... Make a dict with the keys being string.ascii_lowercase and the values being string.ascii_uppercase. You could then use that dict to capitalize the first letter (if that letter is a key in the dict) without needing to use str.capitalize().

Thank you for your comment. I changed the code as you suggested and sorry if I committed many changes because it's my first contribution.

[cclauss]

No problems ... Commit as many times as you want. We are experimenting to get the right solution.

How could we streamline things using dict.get() ? https://docs.python.org/3/library/stdtypes.html#dict.get

[mohammadreza490]

No problems ... Commit as many times as you want. We are experimenting to get the right solution.

How could we streamline things using dict.get() ? https://docs.python.org/3/library/stdtypes.html#dict.get

I think we can do something like this:

lower_upper_dict = {
        lower: upper for lower, upper in zip(ascii_lowercase, ascii_uppercase)
    }
first_letter_upper  = lower_upper_dict.get(first_letter)
if(first_letter_upper != None):
    new_sentence = first_letter_upper + sentence[1:]
else:
    new_sentence =  sentence

[cclauss]

Let's use the default parameter of dict.get(). Hint: define the dict first and then define first_character second.

[mohammadreza490]

Let's use the default parameter of dict.get(). Hint: define the dict first and then define first_character second.

What about this?

def capitalize(sentence: str) -> str:
    lower_upper_dict = {
        lower: upper for lower, upper in zip(string.ascii_lowercase, string.ascii_uppercase)
    }
    first_letter = lower_upper_dict.get(sentence[0],sentence[0]) #default value is the first character itself
    new_sentence = first_letter + sentence[1:]
    return new_sentence

[cclauss]

Nice! Now, can you shrink those last three lines into just one line?

[mohammadreza490]

Nice! Now, can you shrink those last three lines into just one line?

Well it seems it's possible:

def capitalize(sentence: str) -> str:
    lower_upper_dict = {
        lower: upper for lower, upper in zip(string.ascii_lowercase, string.ascii_uppercase)
    }
    return  lower_upper_dict.get(sentence[0],sentence[0]) + sentence[1:]

[cclauss]

Looking great!! We need two more doctests: The empty string ("") will raise an error and a single lowercase letter ("a").

[mohammadreza490]

Looking great!! We need two more doctests: The empty string ("") will raise an error and a single lowercase letter ("a").

I fixed them by checking the length of the string. It returns the capital of a single letter and returns an empty string for ""

from string import ascii_lowercase, ascii_uppercase


def capitalize(sentence: str) -> str:
    lower_upper_dict = {
        lower: upper for lower, upper in zip(ascii_lowercase, ascii_uppercase)
    }
    return (
        lower_upper_dict.get(sentence[0], sentence[0])
        + (sentence[1:] if (len(sentence) >= 1) else "")
        if (len(sentence) != 0)
        else ""
    )

[cclauss]

Awesome work!! Thanks.

[mohammadreza490]

Awesome work!! Thanks.

Thanks for your help. I learned new things as well