Skip to content

Server fails to respond to Hello message if there aren't bulletins in the Db #142

@vinloren

Description

@vinloren

I cloned the repository to my Windows PC and configured my installation with no problem but as I tried it sending Hello message to the device connected to the BBS I got the following error:

"D:\TC2-BBS-mesh-NA\message_processing.py", line 137, in process_message
handlers[message_lower](sender_id, interface)
File "D:\TC2-BBS-mesh-NA\command_handlers.py", line 85, in handle_bulletin_command
response = f"📰Bulletin Menu📰\nSelect the board to enter?\n[G]eneral (" + datum(date[0]) + ")\n"
~~~~^^^
TypeError: 'NoneType' object is not subscriptable

I eventually discovered that the cause of this bug is due to the application non handling the case of bullettin table empty which produces a None result. I then wrote a fake bulletin using Sqlite3 DB Browser and the access to the BBS via Hello or B message was solved. The problem however showed up again when I tried to access the B (bulletin) menu since also for Info, News, and Urgent boards the application does not handle the case of None result. I then inserted a fake bulletin viaDB Browser for each different board and after that th Bulletin menu did work fine.

I think correcting this issue is necessary to avoid possible disaffection of users to this remarkable project.

P.S: I'd like to highlight the fact that above bug was found on the ReneKlever forked version and actually I wanted to address the issue to him but unfortunately while signalling the issue I dropped here.. This problem did not occur on the original TC2-BBS version whatsoever. Sorry for the inconvenience but I could not address Rene Klever on his repository.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions