Skip to content

fix: bypass passwordless login when totpSecret is configured #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awsl1414 wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

fix: bypass passwordless login when totpSecret is configured #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/browser/auth/Login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,38 @@ export class Login {
}

case 'LOGIN_PASSWORDLESS': {
// If totpSecret is configured, bypass passwordless to reach the TOTP code entry page
if (account.totpSecret) {
this.bot.logger.info(
this.bot.isMobile,
'LOGIN',
'TOTP secret configured, attempting to bypass passwordless flow'
)

const otherWaysLink = await page
.waitForSelector(this.selectors.otherWaysToSignIn, { state: 'visible', timeout: 3000 })
.catch(() => null)

if (otherWaysLink) {
this.bot.logger.info(this.bot.isMobile, 'LOGIN', 'Found "Other ways to sign in" link')
await this.bot.browser.utils.ghostClick(page, this.selectors.otherWaysToSignIn)
await page.waitForLoadState('networkidle', { timeout: 5000 }).catch(() => {
this.bot.logger.debug(
this.bot.isMobile,
'LOGIN',
'Network idle timeout after clicking other ways'
)
})
return true
}

this.bot.logger.warn(
this.bot.isMobile,
'LOGIN',
'Could not find "Other ways to sign in", falling back to manual approval'
)
}

this.bot.logger.info(this.bot.isMobile, 'LOGIN', 'Handling passwordless authentication')
await this.passwordlessLogin.handle(page)
await page.waitForLoadState('networkidle', { timeout: 5000 }).catch(() => {
Expand Down