Skip to content

add: Configuration Warnings and Asserts#46

Merged
ThePat02 merged 12 commits into2.0.0from
feat-config-warnings
Dec 13, 2023
Merged

add: Configuration Warnings and Asserts#46
ThePat02 merged 12 commits into2.0.0from
feat-config-warnings

Conversation

@ThePat02
Copy link
Copy Markdown
Owner

@ThePat02 ThePat02 commented Nov 30, 2023

Add configuration warnings and asserts to the FSM and BT nodes.

@ThePat02 ThePat02 added the enhancement New feature or request label Nov 30, 2023
@ThePat02 ThePat02 self-assigned this Nov 30, 2023
@ThePat02 ThePat02 linked an issue Nov 30, 2023 that may be closed by this pull request
Add warnings/asserts to FSM and BT nodes #17
Closed
@ThePat02 ThePat02 changed the base branch from main to 2.0.0 November 30, 2023 22:40
@ThePat02
Squashed commit of the following:
4a658cc 
commit 1fa64e4
Author: Pat <27511950+ThePat02@users.noreply.github.com>
Date:   Fri Dec 1 10:59:01 2023 +0100

    misc: Color coded folders

commit 63e85ae
Author: Pat <27511950+ThePat02@users.noreply.github.com>
Date:   Fri Dec 1 10:54:39 2023 +0100

    Upgrade to Godot 4.2
@ThePat02
fix
c565207
@ThePat02
add: Basic warnings for the BT
a14c613
@ThePat02
misc
953d76b
@ThePat02
add: Leaf warnings
6b44dfa
@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 1, 2023

Problem: Reset buttons on exported properties are randomly disappearing. Might be related to setter on exported properties with the type of node?

@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 1, 2023

Basically you need to reload the scene before getting to reset any properties.

@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 1, 2023

Bug not related. #48

@ThePat02 ThePat02 marked this pull request as ready for review December 9, 2023 12:21
@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 9, 2023

I implemented some basic warnings for both FSM and BT.
@SirPigeonz Could you just check your project if any weird warnings show up on working trees? After that it should be ready to merge.

@SirPigeonz
Copy link
Copy Markdown
Contributor

SirPigeonz commented Dec 10, 2023

I implemented some basic warnings for both FSM and BT. @SirPigeonz Could you just check your project if any weird warnings show up on working trees? After that it should be ready to merge.

Seems to work fine :)

@SirPigeonz
Copy link
Copy Markdown
Contributor

SirPigeonz commented Dec 10, 2023

@ThePat02
Note. We just need to point in docs that if you extend nodes, you should add @tool in your script if you want warnings.
Also, extended nodes in the demo don't have updated scripts with @tool.

@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 11, 2023

@ThePat02

Note. We just need to point in docs that if you extend nodes, you should add @tool in your script if you want warnings.

Also, extended nodes in the demo don't have updated scripts with @tool.

Good point. Also adding tool keyword to the templates. I am not sure if warnings work even without tool on scripts extending a tool script? Can't test it right now, but I remember fiddling around with this earlier.

@ThePat02 ThePat02 added this to the v2.0.0 milestone Dec 11, 2023
@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 12, 2023

Note. We just need to point in docs that if you extend nodes, you should add @tool in your script if you want warnings.
Also, extended nodes in the demo don't have updated scripts with @tool.

Here are warnings working without the @tool keyword. This weirdly only applies to newly added nodes. Nodes from the example scene do not work...
image
image
Adding new ones enables the warnings again.
image

@SirPigeonz Any idea what causes this weird behaviour?

@SirPigeonz
Copy link
Copy Markdown
Contributor

SirPigeonz commented Dec 12, 2023

@SirPigeonz Any idea what causes this weird behaviour?

I have no idea :D

@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 12, 2023

I have no idea :D

lol same

@ThePat02
Copy link
Copy Markdown
Owner Author

ThePat02 commented Dec 13, 2023

Adding asserts is postponed until #47 is implemented

@ThePat02 ThePat02 merged commit 8ee66a0 into 2.0.0 Dec 13, 2023
@ThePat02 ThePat02 deleted the feat-config-warnings branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ThePat02 ThePat02

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add warnings/asserts to FSM and BT nodes

2 participants

@ThePat02 @SirPigeonz