Description field of badges should be bytes not bytes32 - smart contracts

[joelamouche]

For longer descriptions.

We would then adapt the front end accordingly.

[V-Vaal]

Hello Antoine.
I’ve forked the repo and created a working branch.
Plan : update contracts to use bytes instead of bytes32 for badge descriptions and add a Foundry test for long descriptions.
Please assign me.

[joelamouche]

Hi @V-Vaal , welcome to The Guild!
Sounds good I will assign it to you

[V-Vaal]

Contracts + Foundry tests are done and pushed.
Working on frontend adaptation next and will update the README accordingly.

[joelamouche]

Contracts + Foundry tests are done and pushed.

Nice!
Please create a PR.

Working on frontend adaptation next and will update the README accordingly.

The only problem with that is that we need to wait for redeployment before we can merge into main. Unless you could find a way to make this retrocompatible...

[V-Vaal]

PR opened.

The solution preserves full V1 ABI compatibility (functions + events unchanged) and adds a V2 API for long descriptions.
No redeployment required to merge. ;-)

[joelamouche]

Thanks for the PR @V-Vaal !
I think there is a slight misunderstanding. I want you to directly upgrade the smart contract to bytes (just bump version in deployment script).
The retrocompatibility issue comes from the frontend, that if updated to support bytes instead of bytes32, would be pointing to the older bytes32 contract until I redeploy contracts. So merging update on contracts is fine, its the frontend that needs retrocompatibility or just leave PR open until I redeploy

[V-Vaal]

Got it, thanks for the clarification.

I rebased the branch to keep only the contract update (switching from bytes32 to bytes) and removed the retrocompat layer.
I also fixed the remaining test and script issues from my first attempt, so everything is now aligned and passing.

For the frontend part, let me know what you prefer : I can handle frontend retrocompat in a separate PR or keep this PR focused on contracts and wait until contracts are redeployed

Happy to adapt to whatever works best for you.

[joelamouche]

Thanks for the work.

Let's definitely keep this PR contract focus. If you can do frontend retrocompat in a separate PR that would be amazing! In that case I will create a dedicated ticket