Skip to content

Fix: Missing particle effects#809

Merged
xezon merged 1 commit into
mainfrom
fix-particles
Aug 4, 2022
Merged

Fix: Missing particle effects#809
xezon merged 1 commit into
mainfrom
fix-particles

Conversation

@xezon

@xezon xezon commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Closes #543
Fixes #424

This change recovers 13 broken particles.

Fixed with tweaking color values

airCarrierExplosion2
airCarrierHotPillarArms
airCarrierJet01Explosion
airCarrierJetExplosion1
airCarrierJetExplosion2
airCarrierJetExplosion3
ArmExplosionSmall01
BarrelExplosion
BuggyNewExplosionArms
FireBaseHowitzerPillarArms
HotPillarArms
MammothTankExplosionArms
SpectreHotPillarArms

Original Zero Hour

terrorist_fx_original.mp4

Patched

terrorist_fx_patched.mp4

@xezon xezon added Bug Something is not working right Major Severity: Minor < Major < Critical < Blocker labels Aug 2, 2022
@commy2

commy2 commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Second commit doesn't load. How many changes did you make?

I support changing alpha 0 to alpha 0.01 if that really fixes these effects. Not a fan of mass replacing here. It will be pain, but we should actually check what each one does.

First commit: So lets say R:3 G:0 B:0 0 doesn't work for whatever reason. Why is the solution to use R:6 G:6 B:6 0? Why not R:3 G:0.01 B:0.01 0.01?

@xezon

xezon commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

The second commit is 247 lines. Let me break it up a bit to try make it show.

@xezon

xezon commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

I broke it into 5 smaller commits and they should load now.

@xezon

xezon commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

I will split this change into 2.

@xezon xezon force-pushed the fix-particles branch 2 times, most recently from 528e1ce to 6944527 Compare August 4, 2022 11:40
@xezon

xezon commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Split completed.

@xezon

xezon commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

I tested with Color1 = R:5 G:5 B:5 0 as opposed to Color1 = R:6 G:6 B:6 0 and the fix did not work.

This fix looks good to me.

@commy2

commy2 commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

So these 13 have been confirmed to not work in 1.04 and are fixed with this?

I wonder what these have in common that the others lack.

@xezon

xezon commented Aug 4, 2022

Copy link
Copy Markdown
Contributor Author

Stalker:

These particlesystems all have 2 things in common:
They have AttachedSystems
Their Color1 = R:3 G:0 B:0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something is not working right Major Severity: Minor < Major < Critical < Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Particles may not render at all if their Alpha min max values are zero GLA Terrorist suicide particle effects looks more spectacular in Generals

4 participants