Skip to content

Strip dev_addr from ids in TTS exporter#204

Merged
vlasebian merged 4 commits intomasterfrom
fix/tts-8558-strip-ids-dev-addr
Apr 29, 2026
Merged

Strip dev_addr from ids in TTS exporter#204
vlasebian merged 4 commits intomasterfrom
fix/tts-8558-strip-ids-dev-addr

Conversation

@vlasebian
Copy link
Copy Markdown
Contributor

@vlasebian vlasebian commented Apr 29, 2026

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1444#issuecomment-4342738364

Changes

  • Strip dev_addr from ids on export for TTS source
  • Fix the iterator for application mode for TTS source
  • Add vendor directory to .gitignore

Testing

Before:

-> % go run ./cmd/ttn-lw-migrate --dry-run tts device --app-api-key $API_KEY --app-id adrian-test-lab --default-grpc-address tti.staging1.cloud.thethings.industries:8884 < devices.txt | jq '.ids'
{
  "device_id": "eui-0004a310001ab188",
  "application_ids": {
    "application_id": "adrian-test-lab"
  },
  "dev_eui": "0004A310001AB188",
  "join_eui": "70B3D57ED0000000",
  "dev_addr": "26002C07"
}

After:

-> % go run ./cmd/ttn-lw-migrate --dry-run tts device --app-api-key $API_KEY --app-id adrian-test-lab --default-grpc-address tti.staging1.cloud.thethings.industries:8884 < devices.txt | jq '.ids'
{
  "device_id": "eui-0004a310001ab188",
  "application_ids": {
    "application_id": "adrian-test-lab"
  },
  "dev_eui": "0004A310001AB188",
  "join_eui": "70B3D57ED0000000"
}
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.

Copy link
Copy Markdown
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but it looks a bit weird to me.

Comment thread pkg/source/tts/source.go
@vlasebian vlasebian merged commit 274d201 into master Apr 29, 2026
3 checks passed
@vlasebian vlasebian deleted the fix/tts-8558-strip-ids-dev-addr branch April 29, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants