-
Notifications
You must be signed in to change notification settings - Fork 3k
Web implementation #4724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Web implementation #4724
Conversation
cb8489c to
c356fa1
Compare
|
I switched the implementation to videojs instead of shaka because it was a pain to switch between html5 video for mp4/basic videos & shaka for hls/dash. |
|
I added new public APIs that are only used for the web right now:
|
682b59a to
79f243c
Compare
|
hey @KrzysztofMoch any update on getting this reviewed or if I need to do something to move this PR forward? I've been using my branch for the past few months. |
Summary
Initial implementation for the web. I decided to use shaka player to support more advanced features (like hls/dash/ads/drm...)
It's missing some features for now (will implement before marking this pr as ready):
external subtitles supportmetadata notificationerror handlingMissing features i don't plan on implementing:
Please ignore biome/nix stuff, i'll remove them once the pr is ready & fix style issues.
Motivation
Fixes #4605
Note that i found some missing APIs while implementing this:
missing-> added but only used on the webmimeTypein sourcestartTimemissing audio/video selections->multi audiosmulti variants (hls/dash only)Test plan
For now i'm just making this PR to share the progress and the initial ideas, my next step is to try those changes with the example app and then with kyoo.