Extract dialog helpers to shared module

[SorraTheOrc]

Summary: Follow-up work item to extract private dialog helpers into a shared module (src/tui/components/dialog-helpers.ts) and reconcile with the modal dialog base (WL-0MNU782BD004HO2W).

Dependencies

• Parent modal abstraction: WL-0MNU782BD004HO2W (design must be considered prior to extraction)

Acceptance Criteria

• New module planned with public signatures documented and migration steps outlined.
• A mapping is produced showing which helpers in DialogsComponent map to exported functions/classes.
• A dependency link to WL-0MNU782BD004HO2W is included in the description.

Mapping: DialogsComponent Private Helpers → Extracted Public API

1. →

• Current: Private method in DialogsComponent (line ~470)

• Purpose: Creates a configured Blessed List with sensible defaults for dialogs

• Proposed Public Signature:

• Migration: Replace calls with

2. →

• Current: Private method in DialogsComponent (line ~485)

• Purpose: Creates a configured Blessed Textarea with sensible defaults

• Proposed Public Signature:

• Migration: Replace calls with

3. →

• Current: Private method in DialogsComponent (line ~500)

• Purpose: Creates a label box used as section headers inside dialogs

• Proposed Public Signature:

• Migration: Replace calls with

Migration Steps (to be executed in child work items)

1. Create shared dialog-helpers module (WL-0MO5SBA2C0011DXJ)

   • Create
   • Export type definitions for options interfaces
   • Implement , ,
   • Re-export common types (BlessedBox, BlessedList, BlessedTextarea)

2. Migrate DialogsComponent to use helpers (WL-0MO5SBPQW006ZZ3Q)

   • Import helpers from dialog-helpers.ts
   • Replace private method implementations with imports
   • Ensure all existing functionality preserved

3. Integration & compatibility

   • Modal base interop (WL-0MO5SBWCA0027QKV)
   • Test verification (WL-0MO5SBZ3U0007M40)

Compatibility Notes

• All functions maintain backward-compatible parameter shapes
• No breaking changes to Widget lifecycle (create/destroy)
• Theme integration preserved via existing import
• Tests must pass after migration to verify behavioral parity

[SorraTheOrc]

pi-agent

Planning Complete. Created 6 child feature work items:

1. Create shared dialog-helpers module (WL-0MO5SBA2C0011DXJ)
2. Migrate DialogsComponent to use helpers (WL-0MO5SBPQW006ZZ3Q) — depends on wl gh push: sub-issue self-link error when parent and child share same githubIssueNumber #1
3. Textarea & cursor integration parity (WL-0MO5SBU2L002DLY4) — depends on wl gh push: sub-issue self-link error when parent and child share same githubIssueNumber #1, Clear corrupted githubIssueNumber data for 33 items sharing issue 675 #2
4. Modal base & modals interop (WL-0MO5SBWCA0027QKV) — depends on Clear corrupted githubIssueNumber data for 33 items sharing issue 675 #2
5. Integration parity & visual smoke tests (WL-0MO5SBZ3U0007M40) — depends on wl gh push: sub-issue self-link error when parent and child share same githubIssueNumber #1-4
6. Cleanup, docs & migration mapping (WL-0MO5SC3MG002M6JA) — depends on all prior

Open Questions:

• API shape for helpers: Should helpers accept a single generic options object or narrow typed params? (Unresolved - user preference pending)

Appendix (Q/A transcript):

• Q1: Scope & output? → A: C (Full extraction)
• Q2: API shape preference? → A: D (Undecided)
• Q3: Compatibility & rollout? → A: D (Just do it, as long as tests pass)
• Readiness: Proceed now? → A: yes

All dependencies added between features. Stage updated to plan_complete.

[SorraTheOrc]

effort_and_risk_skill

Effort and Risk Report

Effort | Medium | 24.83h
Risk | Medium | 9/20
Confidence | 88% | unknowns: API shape (options vs typed params) - OPEN QUESTION; Actual test coverage for visual parity

{
  "effort": {
    "unit": "hours",
    "tshirt": "Medium",
    "o": 14.0,
    "m": 24.0,
    "p": 39.0,
    "expected": 24.83,
    "recommended": 34.83,
    "range": [
      24.0,
      49.0
    ]
  },
  "risk": {
    "probability": 3.07,
    "impact": 3.07,
    "score": 9,
    "level": "Medium",
    "top_drivers": [
      "Migrate DialogsComponent to use helpers",
      "Create shared dialog-helpers module",
      "Textarea & cursor integration parity"
    ],
    "mitigations": [
      "Add targeted tests and integration checks",
      "Lock dependencies and add compatibility tests",
      "Schedule extra review for risky components"
    ]
  },
  "confidence_percent": 88,
  "assumptions": [
    "dialog-helpers.ts can be extracted without changing widget behavior",
    "modal-base APIs are stable for interop",
    "User tests pass after migration"
  ],
  "unknowns": [
    "API shape (options vs typed params) - OPEN QUESTION",
    "Actual test coverage for visual parity"
  ]
}

[SorraTheOrc]

pi-agent

Planning complete - created mapping of private helpers to public API signatures for dialog extraction

[SorraTheOrc]

pi-agent

PR created: #1535 - Ready for review and merge.