Skip to content

Add dialog parity PR checklist (WL-0MO5O00UN001OD9J) #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SorraTheOrc wants to merge 1 commit into from
Closed

Add dialog parity PR checklist (WL-0MO5O00UN001OD9J) #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions docs/PR_CHECKLIST_DIALOG_PARITY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# Dialog Parity PR Checklist

This checklist should be completed by a reviewer when changes affect the TUI dialogs component (`src/tui/components/dialogs.ts`).

## Manual Verification Steps

### Create Dialog (Shift+C)

- [ ] **Open Create Dialog**: Press `Shift+C` to open the create dialog
- [ ] **Confirm fields present**:
- [ ] Title input field is visible and focused
- [ ] Description textarea is visible
- [ ] Issue Type dropdown/list is visible with options (bug, feature, task, epic, chore)
- [ ] Priority dropdown/list is visible with options (critical, high, medium, low)
- [ ] **Submit**: Fill in a test title and description, press `Ctrl+S` to submit
- [ ] **Verify**:
- [ ] Toast message confirms creation ("Created:")
- [ ] Dialog closes after successful submission
- [ ] New item appears in the work item list

### Update Dialog (u)

- [ ] **Open Update Dialog**: Press `u` while a work item is selected
- [ ] **Verify fields present**:
- [ ] Status options list is visible
- [ ] Stage options list is visible
- [ ] Priority options list is visible
- [ ] Comment textarea is visible
- [ ] **Change Priority**: Select a different priority from the dropdown
- [ ] **Submit**: Press `Ctrl+S` to save changes
- [ ] **Verify**:
- [ ] Toast message confirms update
- [ ] Changes are persisted (item shows new priority)
- [ ] Dialog closes

### Visual Inspection

- [ ] **Modal Borders**: All dialogs have visible border lines
- [ ] **Labels**: Each dialog has a label (title bar) correctly displayed
- [ ] **Positioning**: Dialogs are centered on screen
- [ ] **Styling**: Border colors are consistent (green for details, magenta for close, etc.)
- [ ] **Responsive**: Dialogs adapt to terminal resize

## Reviewer Confirmation

> I have completed the manual verification steps above and confirm that the dialogs render and function correctly after these changes.

**Reviewer**: _________________
**Date**: _________________

**Notes** (optional):
```

```
Loading