Added client context, with a disclaimer that it can be re-used.#91
Merged
Conversation
Theldus
approved these changes
Aug 8, 2024
Owner
Theldus
left a comment
Theldus
left a comment
There was a problem hiding this comment.
Hi @dkorolev,
Thank you for the PR.
I don't know why this took me so long to add, considering it's a feature that's been requested for at least two years. Thanks for considering my suggestions via email, it's exactly as I imagined.
Pls kindly let me sleep over how to best handle the fact that the same client context may be re-used.
As for my concern about whether it's usable after closing the connection, I don't think there's an issue like I thought: the user can't assume that the connection data still exists after it's closed, so we can move forward with this =).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Theldus , this follows your comment from 2022: #48 (comment).
Pls kindly let me sleep over how to best handle the fact that the same client context may be re-used.