-
Notifications
You must be signed in to change notification settings - Fork 11
feat: use tanstack query for workspaces #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce41635
feat: use tanstack query for workspaces
urjitc 7654978
fix: bugs
urjitc e15cdc4
Merge branch 'main' into feat/use-tanstack-query-for-home-page
urjitc a3b7cdc
fix
urjitc a983c88
Merge branch 'feat/use-tanstack-query-for-home-page' of https://githu…
urjitc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n src/contexts/WorkspaceContext.tsx | head -150Repository: ThinkEx-OSS/thinkex
Length of output: 6474
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 3909
🏁 Script executed:
fd "auth-client" --type fRepository: ThinkEx-OSS/thinkex
Length of output: 85
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 693
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 90
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 6713
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 1545
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 10936
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 6759
🏁 Script executed:
rg "queryClient.clear|removeQueries" -B 3 -A 3Repository: ThinkEx-OSS/thinkex
Length of output: 45
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 45
🏁 Script executed:
rg "QueryClientProvider\|QueryClient" -B 3 -A 3Repository: ThinkEx-OSS/thinkex
Length of output: 45
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 566
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 1524
🏁 Script executed:
rg "session.*invalidate\|invalidate.*session\|onSignOut\|onAuthChange" -B 3 -A 3Repository: ThinkEx-OSS/thinkex
Length of output: 45
🏁 Script executed:
Repository: ThinkEx-OSS/thinkex
Length of output: 3730
Scope the workspaces query by user/session and fix async contract violations.
The static
queryKey: ['workspaces']on line 61 creates a cross-user cache leak risk—if the session changes without a full reload, React Query will briefly surface cached workspaces from a previous user. Additionally, the query lacks anenabledcondition to prevent requests during auth transitions.More critically, the wrapper functions
deleteWorkspace(line 158) andreorderWorkspaces(line 224) violate their async contract: both havePromise<void>return types but callmutate()without awaiting, causing callers to receive resolved promises before mutations complete. UsemutateAsync()instead.✅ Suggested adjustments
For
deleteWorkspace:const deleteWorkspace = useCallback( async (workspaceId: string) => { - deleteWorkspaceMutation.mutate(workspaceId); + return deleteWorkspaceMutation.mutateAsync(workspaceId); [deleteWorkspaceMutation] );For
reorderWorkspaces:const reorderWorkspaces = useCallback( async (workspaceIds: string[]) => { - reorderWorkspacesMutation.mutate(workspaceIds); + return reorderWorkspacesMutation.mutateAsync(workspaceIds); [reorderWorkspacesMutation] );🤖 Prompt for AI Agents