Skip to content

Revert "Refactor performance optimizations and security headers" - #20

Merged
urjitc merged 1 commit into
mainfrom
revert-19-refactor/no-ref/performance-optimizations-and-security-headers
Jan 15, 2026
Merged

Revert "Refactor performance optimizations and security headers"#20
urjitc merged 1 commit into
mainfrom
revert-19-refactor/no-ref/performance-optimizations-and-security-headers

Conversation

@urjitc

@urjitc urjitc commented Jan 15, 2026

Copy link
Copy Markdown
Member

Reverts #19


Important

Reverts performance optimizations and security headers, affecting configuration, API routes, and components.

  • Revert Changes:
  • Configuration:
    • Removes optimizePackageImports from next.config.ts.
    • Deletes vercel.json which contained security headers.
  • API Routes:
    • Reverts parallelization changes in route.ts and events/route.ts.
  • Components:
    • Removes unoptimized attribute from Image components in FourWays.tsx and ThreeSteps.tsx.

This description was created by Ellipsis for 51d1dcf. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores

    • Removed internal skill documentation and guidance files.
    • Removed Vercel configuration for HTTP headers and caching policies.
    • Simplified API route handlers to use sequential request processing instead of parallel operations.
  • Style

    • Added unoptimized prop to image components.
    • Removed barrel-import optimization configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@greptile-apps

greptile-apps Bot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Skipped: This PR changes more files than the configured file change limit: (111 files found, 100 file limit)

@vercel

vercel Bot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
thinkexv2 Building Building Preview, Comment Jan 15, 2026 2:00am

@coderabbitai

coderabbitai Bot commented Jan 15, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes comprehensive React/Next.js best-practices documentation and skill definitions, simplifies API route parameter handling from parallel to sequential execution, eliminates Vercel configuration headers, removes Next.js barrel-import optimization, and adds unoptimized Image rendering in landing components.

Changes

Cohort / File(s) Summary
Documentation and Skills Removal
.claude/skills/vercel-react-best-practices/*
.github/skills/vercel-react-best-practices/*
.github/skills/web-design-guidelines/SKILL.md
Deleted comprehensive React/Next.js optimization guide (~2,250 lines), including AGENTS.md (AI agent reference), README.md (project docs), SKILL.md (skill definition), metadata.json, rule templates, and ~50+ individual rule files covering waterfalls, bundling, server/client performance, re-rendering, rendering optimization, JavaScript patterns, and advanced techniques. Skill definitions for web-design-guidelines also removed.
API Route Parameter Handling
src/app/api/workspaces/[id]/events/route.ts
src/app/api/workspaces/[id]/route.ts
src/app/api/workspaces/slug/[slug]/route.ts
Changed async orchestration from parallel promise initiation to sequential awaiting. Routes now resolve params, then headers, then body sequentially instead of concurrently. Timing instrumentation relocated; control flow simplified. GET/POST/PATCH/DELETE handlers refactored with direct await patterns replacing intermediate Promise variables.
Configuration Removals
vercel.json
Deleted entire Vercel configuration file containing global security headers (HSTS, X-Frame-Options, X-XSS-Protection, Referrer-Policy, Permissions-Policy), route-specific cache-control directives for API and static assets, and asset caching policies for images/fonts/JS/CSS.
Next.js Config
next.config.ts
Removed experimental.optimizePackageImports configuration for lucide-react barrel-import optimization.
Image Component Optimization
src/components/landing/FourWays.tsx
src/components/landing/ThreeSteps.tsx
Added unoptimized prop to Next.js Image components for both mobile and desktop render paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A skills library fades to dust,
Sequential flows replace the thrust,
Headers and images now unbound,
Config files without a sound—
Simpler paths, the code grows light! 🌙

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51965d3 and 51d1dcf.

📒 Files selected for processing (111)
  • .claude/skills/vercel-react-best-practices/AGENTS.md
  • .claude/skills/vercel-react-best-practices/README.md
  • .claude/skills/vercel-react-best-practices/SKILL.md
  • .claude/skills/vercel-react-best-practices/metadata.json
  • .claude/skills/vercel-react-best-practices/rules/_sections.md
  • .claude/skills/vercel-react-best-practices/rules/_template.md
  • .claude/skills/vercel-react-best-practices/rules/advanced-event-handler-refs.md
  • .claude/skills/vercel-react-best-practices/rules/advanced-use-latest.md
  • .claude/skills/vercel-react-best-practices/rules/async-api-routes.md
  • .claude/skills/vercel-react-best-practices/rules/async-defer-await.md
  • .claude/skills/vercel-react-best-practices/rules/async-dependencies.md
  • .claude/skills/vercel-react-best-practices/rules/async-parallel.md
  • .claude/skills/vercel-react-best-practices/rules/async-suspense-boundaries.md
  • .claude/skills/vercel-react-best-practices/rules/bundle-barrel-imports.md
  • .claude/skills/vercel-react-best-practices/rules/bundle-conditional.md
  • .claude/skills/vercel-react-best-practices/rules/bundle-defer-third-party.md
  • .claude/skills/vercel-react-best-practices/rules/bundle-dynamic-imports.md
  • .claude/skills/vercel-react-best-practices/rules/bundle-preload.md
  • .claude/skills/vercel-react-best-practices/rules/client-event-listeners.md
  • .claude/skills/vercel-react-best-practices/rules/client-swr-dedup.md
  • .claude/skills/vercel-react-best-practices/rules/js-batch-dom-css.md
  • .claude/skills/vercel-react-best-practices/rules/js-cache-function-results.md
  • .claude/skills/vercel-react-best-practices/rules/js-cache-property-access.md
  • .claude/skills/vercel-react-best-practices/rules/js-cache-storage.md
  • .claude/skills/vercel-react-best-practices/rules/js-combine-iterations.md
  • .claude/skills/vercel-react-best-practices/rules/js-early-exit.md
  • .claude/skills/vercel-react-best-practices/rules/js-hoist-regexp.md
  • .claude/skills/vercel-react-best-practices/rules/js-index-maps.md
  • .claude/skills/vercel-react-best-practices/rules/js-length-check-first.md
  • .claude/skills/vercel-react-best-practices/rules/js-min-max-loop.md
  • .claude/skills/vercel-react-best-practices/rules/js-set-map-lookups.md
  • .claude/skills/vercel-react-best-practices/rules/js-tosorted-immutable.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-activity.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-animate-svg-wrapper.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-conditional-render.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-content-visibility.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-hoist-jsx.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-hydration-no-flicker.md
  • .claude/skills/vercel-react-best-practices/rules/rendering-svg-precision.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-defer-reads.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-dependencies.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-derived-state.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-functional-setstate.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-lazy-state-init.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-memo.md
  • .claude/skills/vercel-react-best-practices/rules/rerender-transitions.md
  • .claude/skills/vercel-react-best-practices/rules/server-after-nonblocking.md
  • .claude/skills/vercel-react-best-practices/rules/server-cache-lru.md
  • .claude/skills/vercel-react-best-practices/rules/server-cache-react.md
  • .claude/skills/vercel-react-best-practices/rules/server-parallel-fetching.md
  • .claude/skills/vercel-react-best-practices/rules/server-serialization.md
  • .claude/skills/web-design-guidelines/SKILL.md
  • .github/skills/vercel-react-best-practices/AGENTS.md
  • .github/skills/vercel-react-best-practices/README.md
  • .github/skills/vercel-react-best-practices/SKILL.md
  • .github/skills/vercel-react-best-practices/metadata.json
  • .github/skills/vercel-react-best-practices/rules/_sections.md
  • .github/skills/vercel-react-best-practices/rules/_template.md
  • .github/skills/vercel-react-best-practices/rules/advanced-event-handler-refs.md
  • .github/skills/vercel-react-best-practices/rules/advanced-use-latest.md
  • .github/skills/vercel-react-best-practices/rules/async-api-routes.md
  • .github/skills/vercel-react-best-practices/rules/async-defer-await.md
  • .github/skills/vercel-react-best-practices/rules/async-dependencies.md
  • .github/skills/vercel-react-best-practices/rules/async-parallel.md
  • .github/skills/vercel-react-best-practices/rules/async-suspense-boundaries.md
  • .github/skills/vercel-react-best-practices/rules/bundle-barrel-imports.md
  • .github/skills/vercel-react-best-practices/rules/bundle-conditional.md
  • .github/skills/vercel-react-best-practices/rules/bundle-defer-third-party.md
  • .github/skills/vercel-react-best-practices/rules/bundle-dynamic-imports.md
  • .github/skills/vercel-react-best-practices/rules/bundle-preload.md
  • .github/skills/vercel-react-best-practices/rules/client-event-listeners.md
  • .github/skills/vercel-react-best-practices/rules/client-swr-dedup.md
  • .github/skills/vercel-react-best-practices/rules/js-batch-dom-css.md
  • .github/skills/vercel-react-best-practices/rules/js-cache-function-results.md
  • .github/skills/vercel-react-best-practices/rules/js-cache-property-access.md
  • .github/skills/vercel-react-best-practices/rules/js-cache-storage.md
  • .github/skills/vercel-react-best-practices/rules/js-combine-iterations.md
  • .github/skills/vercel-react-best-practices/rules/js-early-exit.md
  • .github/skills/vercel-react-best-practices/rules/js-hoist-regexp.md
  • .github/skills/vercel-react-best-practices/rules/js-index-maps.md
  • .github/skills/vercel-react-best-practices/rules/js-length-check-first.md
  • .github/skills/vercel-react-best-practices/rules/js-min-max-loop.md
  • .github/skills/vercel-react-best-practices/rules/js-set-map-lookups.md
  • .github/skills/vercel-react-best-practices/rules/js-tosorted-immutable.md
  • .github/skills/vercel-react-best-practices/rules/rendering-activity.md
  • .github/skills/vercel-react-best-practices/rules/rendering-animate-svg-wrapper.md
  • .github/skills/vercel-react-best-practices/rules/rendering-conditional-render.md
  • .github/skills/vercel-react-best-practices/rules/rendering-content-visibility.md
  • .github/skills/vercel-react-best-practices/rules/rendering-hoist-jsx.md
  • .github/skills/vercel-react-best-practices/rules/rendering-hydration-no-flicker.md
  • .github/skills/vercel-react-best-practices/rules/rendering-svg-precision.md
  • .github/skills/vercel-react-best-practices/rules/rerender-defer-reads.md
  • .github/skills/vercel-react-best-practices/rules/rerender-dependencies.md
  • .github/skills/vercel-react-best-practices/rules/rerender-derived-state.md
  • .github/skills/vercel-react-best-practices/rules/rerender-functional-setstate.md
  • .github/skills/vercel-react-best-practices/rules/rerender-lazy-state-init.md
  • .github/skills/vercel-react-best-practices/rules/rerender-memo.md
  • .github/skills/vercel-react-best-practices/rules/rerender-transitions.md
  • .github/skills/vercel-react-best-practices/rules/server-after-nonblocking.md
  • .github/skills/vercel-react-best-practices/rules/server-cache-lru.md
  • .github/skills/vercel-react-best-practices/rules/server-cache-react.md
  • .github/skills/vercel-react-best-practices/rules/server-parallel-fetching.md
  • .github/skills/vercel-react-best-practices/rules/server-serialization.md
  • .github/skills/web-design-guidelines/SKILL.md
  • next.config.ts
  • src/app/api/workspaces/[id]/events/route.ts
  • src/app/api/workspaces/[id]/route.ts
  • src/app/api/workspaces/slug/[slug]/route.ts
  • src/components/landing/FourWays.tsx
  • src/components/landing/ThreeSteps.tsx
  • vercel.json

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@urjitc
urjitc merged commit 68a50f8 into main Jan 15, 2026
4 of 7 checks passed
@urjitc
urjitc deleted the revert-19-refactor/no-ref/performance-optimizations-and-security-headers branch January 15, 2026 02:00
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Dev Board Jan 15, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 111 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 51d1dcf in 2 minutes and 22 seconds. Click for details.
  • Reviewed 10697 lines of code in 111 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. next.config.ts:12
  • Draft comment:
    Using a wildcard hostname '**' in remotePatterns can be overly permissive. Consider restricting allowed domains to trusted hosts to reduce potential abuse.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. src/components/landing/FourWays.tsx:310
  • Draft comment:
    Ensure the use of the 'unoptimized' property on Next.js Image components is intentional, as it disables built-in image optimization and may impact performance.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. src/components/landing/ThreeSteps.tsx:80
  • Draft comment:
    Verify that using the 'unoptimized' flag on the Next.js Image component is intentional, as it bypasses built-in image optimization which might affect image delivery performance.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_nTJuNsnP7l7wpMmC

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant