Skip to content

Replace assistant-ui Viewport with custom scroll controller for virtualized thread #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
urjitc wants to merge 12 commits into from
Closed

Replace assistant-ui Viewport with custom scroll controller for virtualized thread #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5aaf4cc
Replace assistant-ui Viewport with custom scroll controller to resolv…
urjitc Apr 17, 2026
4083551
fix(thread): use virtualizer.scrollToIndex + live message count
urjitc Apr 17, 2026
9dd0382
perf(thread): align virtualized thread with TanStack Virtual docs
urjitc Apr 17, 2026
7e8fcb9
refactor(thread): trim bloat from virtualized thread
urjitc Apr 17, 2026
96dc783
fix(thread): per-row translateY for non-contiguous virtual items
urjitc Apr 17, 2026
f704e52
fix(thread): bottom slack + reliable thread-switch scroll
urjitc Apr 18, 2026
8553ade
refactor(thread): drive thread-switch scroll via useAuiState subscrip…
urjitc Apr 18, 2026
633c181
fix(thread): read live message count in runStart handler
urjitc Apr 18, 2026
2f5a44d
refactor(thread): swap @tanstack/react-virtual for virtua
urjitc Apr 18, 2026
197db37
fix(thread): post-commit scroll via isRunning effect instead of runSt…
urjitc Apr 18, 2026
5eb8230
fix(thread): keep slack allocated after streaming ends
urjitc Apr 18, 2026
9e59bf6
fix(thread): correct scroll target + hover cleanup + thread-switch leak
urjitc Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"@tanstack/react-pacer": "^0.21.1",
"@tanstack/react-query": "^5.96.1",
"@tanstack/react-query-devtools": "^5.96.1",
"@tanstack/react-virtual": "^3.13.23",
"virtua": "^0.49.1",

@coderabbitai coderabbitai Bot Apr 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Description: Verify pnpm lockfile reflects the package.json virtualizer change.
# Expected: pnpm-lock.yaml exists, contains virtua, and does not contain `@tanstack/react-virtual`.

test -f pnpm-lock.yaml
rg -n '"?virtua"?|/virtua@' pnpm-lock.yaml
if rg -n '@tanstack/react-virtual' pnpm-lock.yaml; then
  printf 'Stale `@tanstack/react-virtual` lockfile entry found\n' >&2
  exit 1
fi

Repository: ThinkEx-OSS/thinkex

Length of output: 45

🏁 Script executed:

#!/bin/bash
# Check if pnpm-lock.yaml exists and examine virtualizer entries

echo "=== Checking pnpm-lock.yaml existence ==="
if [ -f pnpm-lock.yaml ]; then
  echo "✓ pnpm-lock.yaml exists"
  echo ""
  echo "=== Searching for 'virtua' entries ==="
  rg -i 'virtua' pnpm-lock.yaml | head -20
  echo ""
  echo "=== Searching for '@tanstack/react-virtual' entries ==="
  rg '@tanstack/react-virtual' pnpm-lock.yaml | head -20
else
  echo "✗ pnpm-lock.yaml does NOT exist"
fi

echo ""
echo "=== Checking package.json for virtua ==="
rg 'virtua' package.json

Repository: ThinkEx-OSS/thinkex

Length of output: 203

Add pnpm-lock.yaml to the commit.

The virtua dependency has been added to package.json but pnpm-lock.yaml is missing from the repository. Projects using pnpm require the lockfile to ensure reproducible installs. Run pnpm install locally to generate and commit the updated lockfile.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 96, package.json now includes the new dependency
"virtua" but the generated pnpm lockfile is missing; run pnpm install locally to
produce an updated pnpm-lock.yaml, add and commit that pnpm-lock.yaml alongside
the package.json change so installs are reproducible and CI uses the same locked
dependency versions.

"@tiptap/core": "3.22.3",
"@tiptap/extension-code-block": "3.22.3",
"@tiptap/extension-highlight": "3.22.3",
Expand Down
Loading
Loading