-
Notifications
You must be signed in to change notification settings - Fork 648
refactor(window): drop shell tab layer #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Multi-Window Cleanup Plan | ||
|
|
||
| 1. Rename renderer entry from `shell` to `browser` and delete tooltip overlay. | ||
| 2. Convert YoBrowser from single-window multi-tab to multi-window single-page. | ||
| 3. Remove tab shortcuts and tab UI, keep only multi-window behavior. | ||
| 4. Short-circuit tab-dependent legacy MCP helpers. | ||
| 5. Run format, i18n, lint, typecheck, targeted tests, and build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Multi-Window Cleanup Spec | ||
|
|
||
| ## Goal | ||
|
|
||
| Remove the last shell and multi-tab browser architecture remnants and converge on a clean | ||
| multi-window model: | ||
|
|
||
| - app windows render the chat UI directly | ||
| - browser windows render dedicated browser chrome directly | ||
| - each browser window owns exactly one page `WebContentsView` | ||
| - tooltip overlay is removed completely | ||
|
|
||
| ## Decisions | ||
|
|
||
| ### Window model | ||
|
|
||
| - `WindowPresenter` exposes explicit app-window and browser-window creation APIs. | ||
| - `createShellWindow` remains only as a deprecated compatibility wrapper. | ||
| - Browser windows load `src/renderer/browser/index.html`. | ||
| - Chat windows load `src/renderer/index.html#/chat`. | ||
|
|
||
| ### YoBrowser model | ||
|
|
||
| - `YoBrowserPresenter` manages multiple browser windows. | ||
| - Each browser window has one browser chrome renderer and one page view. | ||
| - There is no tab list, no tab activation, no tab reordering, and no tab shortcuts. | ||
| - Browser APIs use `windowId` for addressing. | ||
|
|
||
| ### Renderer model | ||
|
|
||
| - The old `src/renderer/shell` entry is renamed to `src/renderer/browser`. | ||
| - Browser chrome keeps only: | ||
| - window controls | ||
| - address bar | ||
| - navigation controls | ||
| - create-new-browser-window action | ||
| - Tooltip overlay entry/runtime is deleted. | ||
|
|
||
| ### Legacy handling | ||
|
|
||
| - `conversationSearchServer` and `meetingServer` are intentionally disabled until they are rebuilt | ||
| against the window-native architecture. | ||
| - Deprecated browser tool names remain as thin aliases only in the handler. | ||
|
|
||
| ## Non-Goals | ||
|
|
||
| - Rebuilding every legacy session/thread abstraction in this pass. | ||
| - Introducing new UI entities beyond the required browser-window state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Multi-Window Cleanup Tasks | ||
|
|
||
| - [x] Move renderer entry from `shell` to `browser` | ||
| - [x] Delete tooltip overlay entry from renderer tree | ||
| - [ ] Update build aliases and inputs | ||
| - [ ] Simplify browser renderer chrome | ||
| - [ ] Rewrite YoBrowser window model | ||
| - [ ] Split app-window and browser-window creation | ||
| - [ ] Remove tab shortcuts from main/settings | ||
| - [ ] Disable legacy MCP tab helpers | ||
| - [ ] Verify format, i18n, lint, typecheck, tests, build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.