Skip to content

fix: unwatch is not a function error in knowledge settings components #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 1 commit into from
Aug 3, 2025
Merged

fix: unwatch is not a function error in knowledge settings components #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/renderer/src/components/settings/DifyKnowledgeSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,13 +418,13 @@ watch(
)

// 组件挂载时加载配置
let unwatch: () => void // only use here, so declare it here
let unwatch: (() => void) | undefined
onMounted(async () => {
unwatch = watch(
() => mcpStore.config.ready,
async (ready) => {
if (ready) {
unwatch() // only run once to avoid multiple calls
unwatch?.() // only run once to avoid multiple calls
await loadDifyConfigFromMcp()
}
},
Expand All @@ -434,8 +434,6 @@ onMounted(async () => {

// cancel the watch to avoid memory leaks
onUnmounted(() => {
if (unwatch) {
unwatch()
}
unwatch?.()
})
</script>
8 changes: 3 additions & 5 deletions src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,13 +417,13 @@ watch(
)

// 组件挂载时加载配置
let unwatch: () => void // only use here, so declare it here
let unwatch: (() => void) | undefined
onMounted(async () => {
unwatch = watch(
() => mcpStore.config.ready,
async (ready) => {
if (ready) {
unwatch() // only run once to avoid multiple calls
unwatch?.() // only run once to avoid multiple calls
await loadFastGptConfigFromMcp()
}
},
Expand All @@ -433,8 +433,6 @@ onMounted(async () => {

// cancel the watch to avoid memory leaks
onUnmounted(() => {
if (unwatch) {
unwatch()
}
unwatch?.()
})
</script>
8 changes: 3 additions & 5 deletions src/renderer/src/components/settings/RagflowKnowledgeSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,13 +435,13 @@ watch(
)

// 组件挂载时加载配置
let unwatch: () => void // only use here, so declare it here
let unwatch: (() => void) | undefined
onMounted(async () => {
unwatch = watch(
() => mcpStore.config.ready,
async (ready) => {
if (ready) {
unwatch() // only run once to avoid multiple calls
unwatch?.() // only run once to avoid multiple calls
await loadRagflowConfigFromMcp()
}
},
Expand All @@ -451,8 +451,6 @@ onMounted(async () => {

// cancel the watch to avoid memory leaks
onUnmounted(() => {
if (unwatch) {
unwatch()
}
unwatch?.()
})
</script>