-
Notifications
You must be signed in to change notification settings - Fork 648
feat(ui): new design tokens #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
aaea01b
d62d638
33b106e
565c556
da94802
f8f048a
9831d57
4a2e324
b128962
7d050c1
632a1c2
d8bccdc
4017508
ecc6ebf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,8 +1,5 @@ | ||||||
| <template> | ||||||
| <div | ||||||
| class="w-screen h-screen" | ||||||
| :class="[isMacOS ? 'bg-transparent' : themeStore.isDark ? 'bg-zinc-900' : 'bg-zinc-200']" | ||||||
| > | ||||||
| <div class="w-screen h-screen" :class="[isMacOS ? 'bg-transparent' : 'bg-card/50']"> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent token usage: use new The class Apply this diff to use the new token: - <div class="w-screen h-screen" :class="[isMacOS ? 'bg-transparent' : 'bg-card/50']">
+ <div class="w-screen h-screen" :class="[isMacOS ? 'bg-transparent' : 'bg-bg-card/50']">📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| <AppBar /> | ||||||
| <main class="content-container"> | ||||||
| <!-- WebContentsView will be rendered here by the main process --> | ||||||
|
|
@@ -14,9 +11,7 @@ | |||||
| import AppBar from './components/AppBar.vue' | ||||||
| import { ref, onMounted } from 'vue' | ||||||
| import { usePresenter } from '@/composables/usePresenter' | ||||||
| import { useThemeStore } from '@/stores/theme' | ||||||
| const isMacOS = ref(false) | ||||||
| const themeStore = useThemeStore() | ||||||
| const devicePresenter = usePresenter('devicePresenter') | ||||||
| // Shell component setup | ||||||
| onMounted(() => { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
dayjs is under devDependencies; verify runtime usage and move to dependencies if imported in app code.
If dayjs is used at runtime (main/preload/renderer), keeping it in devDependencies risks missing module errors after production prune/packaging. Prefer placing runtime libs in "dependencies".
Run this to confirm where dayjs is used:
If used at runtime, apply:
- "dayjs": "^1.11.18",and add it to "dependencies" (example placement):
"dependencies": { + "dayjs": "^1.11.18", "@anthropic-ai/sdk": "^0.53.0", ... }🏁 Script executed:
Length of output: 246
🏁 Script executed:
Length of output: 457
Move dayjs to dependencies
dayjs is imported in src/renderer/src/components/settings/KnowledgeFileItem.vue and used at runtime; listing it under devDependencies risks it being pruned from production builds. Remove it from devDependencies and add it under dependencies in package.json:
🤖 Prompt for AI Agents