feat: add windows exe build pipeline and fix bundled template path#3
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/build.yml:
- Around line 3-6: The workflow currently triggers only on push to branch "main"
(see on: push branches: [main] and workflow_dispatch), so it never runs for
changes pushed to "develop"; update the triggers to include "develop" (e.g., add
it to the push branches array) or add a pull_request trigger for target branches
(or both) so CI runs for PRs targeting develop/main; modify the on: section
accordingly to include the desired branches/PR events.
- Line 22: Replace the unpinned install command "pip install poetry" in the
workflow step with a pinned version that guarantees PEP 735 support (e.g.
install Poetry 2.3.0 or a constrained range); update the run step to use a
specific version specifier such as "pip install 'poetry>=2.3.0,<3.0.0'" so the
CI consistently uses a Poetry release that supports dependency groups.
In `@audigen_cli/excelWriter.py`:
- Around line 7-10: The _get_base_path function uses sys.MEIPASS which is
incorrect for PyInstaller; change references to sys._MEIPASS and guard access
with hasattr or getattr to avoid AttributeError when not frozen (e.g., use
getattr(sys, '_MEIPASS', None) or hasattr(sys, '_MEIPASS')), so _get_base_path()
returns Path(sys._MEIPASS) when frozen and the normal project folder otherwise;
update any related module-level uses (such as _TEMPLATES evaluation) to rely on
the fixed _get_base_path.
In `@pyproject.toml`:
- Around line 29-31: Add a pinned entry for pyinstaller-hooks-contrib alongside
the existing pyinstaller dev dependency in pyproject.toml: match the version
bounds to pyinstaller (e.g., "pyinstaller-hooks-contrib (>=6.20.0,<7.0.0)") so
both packages are upgraded together and avoid compatibility breakage between
pyinstaller and pyinstaller-hooks-contrib.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b2500a67-d533-4956-91e5-8cfc948a0d76
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.github/workflows/build.ymlaudigen_cli/excelWriter.pypyproject.toml
* developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method
* release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6)
* release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6)
* developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * Sync main into develop (#7) * release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6) * docs: add README, CHANGELOG and update yml file (#8) * Fix/sync main to develop (#9) * release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6)
* developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * Sync main into develop (#7) * release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6) * docs: add README, CHANGELOG and update yml file (#8) * Fix/sync main to develop (#9) * release: merge develop into main (CLI + UX + Windows exe support) (#4) * developed cli for auditgen (#1) * initial setup for basi cli * fix issue in basi cli * feat: improve CLI UX, prompts, and generate workflow * change desing of CLI * fix: address CodeRabbit review comments * fix: check brd file is docx in the flag option * fix: output path issue * feat: add windows exe build pipeline and fix bundled template path (#3) * feat: add windows exe build pipeline and fix bundled template path * fix: get_base_path method * fix: resolve exe crash due to lazy import handling (#5) * fix: lazy import not catch by PyInstaller * fix: add debug in the cli to check what issue it crash (#6) * handle the test result-1 sheet in Test Cases.xsl (#11)
🚀 Summary
This PR adds support for building a Windows executable for AuditGen CLI using PyInstaller and fixes issues with bundled template file path.
✨ Changes Made
.exe<3.15)🧪 Tested
.exeusing PyInstaller📦 Outcome
Users can now run AuditGen CLI as a standalone Windows executable without requiring Python setup.
Summary by CodeRabbit
New Features
Bug Fixes
Chores