Small changes and improvements#1
Conversation
Signed-off-by: xtrm <oss@xtrm.me>
… folder struct, variables & flags Signed-off-by: xtrm <oss@xtrm.me>
…o CFLAGS Signed-off-by: xtrm <oss@xtrm.me>
Signed-off-by: xtrm <oss@xtrm.me>
…ovided Signed-off-by: xtrm <oss@xtrm.me>
Signed-off-by: xtrm <oss@xtrm.me>
Signed-off-by: xtrm <oss@xtrm.me>
…s of header files, removed boost dependancy, removed/added spaces. included @xtrm-en work of PR #1, except his makefile (his makefile is better but i wont copy others work)
KMatias123
left a comment
There was a problem hiding this comment.
Being inconsistent with the indentation is bad since people have different tab widths in their editors but the space width is always the same, so the files will look weird to people with for example 2-wide tabs.
Returning 0 after failing will mostly be a problem if another program is executing construct, as it means EXIT_SUCCESS and the other program will think that construct finished successfully and will continue executing.
|
Apparently vim didnt catch on the spaces, whoops. I'll go back to it in a day or two to fix that, thanks :) |
|
Did some quick merges on the web editor, probably doesn't compile unless i'm lucky lol |
|
(for the record, this compiles now) 👍 |
|
Currently busy with quarterly exams, will look at this soon (week or two), thanks for contributing! |
|
Good luck on your exams and sorry if that sounded spam-ish ^^' |
|
Why is my account inserted in between you guys' conversations? I don't know
any of you guys
Em seg., 30 de dez. de 2024 às 18:09, matias ***@***.***>
escreveu:
… ***@***.**** commented on this pull request.
Forgot to finish this xD
------------------------------
In src/construct.cpp
<#1 (comment)>
:
> }
std::ifstream inpfile(inputfile);
+ if (!inpfile.is_open()) {
+ std::cerr << "Could not open input file" << std::endl;
+ return 1;
+ }
+ if (!inpfile.good()) {
+ std::cerr << "Input file is not good" << std::endl;
This could use a more descriptive
⬇️ Suggested change
- std::cerr << "Input file is not good" << std::endl;
+ std::cerr << "Error reading input file" << std::endl;
Maybe print out the error?
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFZPRNLOXHZGZTOLFDR44IT2IGY63AVCNFSM6AAAAABTSMWFHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBUGU3DIMZWG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Co-authored-by: matias <43719568+KMatias123@users.noreply.github.com>
This PR adds/fixes the following:
bin/to prevent pushing built objs/binaries.ofiles, meaning files will only be recompiled if they have changedCFLAGSandCOPTSfor compilation and optimization flagsCFLAGSNote: The Makefile model is based on my school's Makefiles, so it might be a bit opinionated.
Let me know if anything needs changes and/or total removal and I'll be happy to do so :)