Skip to content

Small changes and improvements#1

Open
qtdyn wants to merge 16 commits into
Thomas-995:masterfrom
x-random-forks:cool-changes
Open

Small changes and improvements#1
qtdyn wants to merge 16 commits into
Thomas-995:masterfrom
x-random-forks:cool-changes

Conversation

@qtdyn

@qtdyn qtdyn commented Jan 24, 2024

Copy link
Copy Markdown

This PR adds/fixes the following:

  • Add .gitignore file
    • Currently only ignores bin/ to prevent pushing built objs/binaries
  • Add proper Makefile
    • This allows for caching of .o files, meaning files will only be recompiled if they have changed
    • Added variables like CFLAGS and COPTS for compilation and optimization flags
  • Fixed warnings related to the introduction of more warning flags in CFLAGS
  • Added some sort of verification for file reading/writing in the input
    • You shouldn't be allowed to pass an input file you can't read or write to somewhere you don't have access to
  • If the output path isn't specifically passed, try and guess it
    • This might be a bit janky? I don't really see how but my gut tells me this is horrible code lol

Note: The Makefile model is based on my school's Makefiles, so it might be a bit opinionated.

Let me know if anything needs changes and/or total removal and I'll be happy to do so :)

qtdyn added 7 commits January 24, 2024 03:09
Signed-off-by: xtrm <oss@xtrm.me>
… folder struct, variables & flags

Signed-off-by: xtrm <oss@xtrm.me>
Signed-off-by: xtrm <oss@xtrm.me>
NoneSince referenced this pull request in NoneSince/construct Jan 24, 2024
…s of header files, removed boost dependancy, removed/added spaces. included @xtrm-en work of PR #1, except his makefile (his makefile is better but i wont copy others work)
@NoneSince NoneSince mentioned this pull request Jan 24, 2024

@KMatias123 KMatias123 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being inconsistent with the indentation is bad since people have different tab widths in their editors but the space width is always the same, so the files will look weird to people with for example 2-wide tabs.

Returning 0 after failing will mostly be a problem if another program is executing construct, as it means EXIT_SUCCESS and the other program will think that construct finished successfully and will continue executing.

Comment thread src/construct.cpp
Comment thread src/construct.cpp Outdated
Comment thread src/construct_debug.cpp Outdated
Comment thread src/construct_flags.cpp Outdated
Comment thread src/deconstruct.cpp Outdated
Comment thread src/reconstruct.cpp Outdated
@qtdyn

qtdyn commented Feb 14, 2024

Copy link
Copy Markdown
Author

Apparently vim didnt catch on the spaces, whoops. I'll go back to it in a day or two to fix that, thanks :)

@qtdyn

qtdyn commented Feb 19, 2024

Copy link
Copy Markdown
Author

Did some quick merges on the web editor, probably doesn't compile unless i'm lucky lol

@qtdyn

qtdyn commented Apr 8, 2024

Copy link
Copy Markdown
Author

(for the record, this compiles now) 👍

@Thomas-995

Copy link
Copy Markdown
Owner

Currently busy with quarterly exams, will look at this soon (week or two), thanks for contributing!

@qtdyn

qtdyn commented Apr 14, 2024

Copy link
Copy Markdown
Author

Good luck on your exams and sorry if that sounded spam-ish ^^'

@qtdyn qtdyn requested a review from KMatias123 December 13, 2024 17:15

@KMatias123 KMatias123 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to finish this xD

Comment thread src/construct.cpp Outdated
@immosfet

immosfet commented Jan 10, 2025 via email

Copy link
Copy Markdown

Co-authored-by: matias <43719568+KMatias123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants