Mabofoul/order in tokentypes#3
Conversation
…s of header files, removed boost dependancy, removed/added spaces. included @xtrm-en work of PR #1, except his makefile (his makefile is better but i wont copy others work)
general improvement
Thomas-995
left a comment
There was a problem hiding this comment.
Like these changes a lot, especially the exception handling stuff. The only thing I'm not sure about is removing the boost library and throwing a bunch of string functions in the deconstruct file. If this could be removed or done differently I'll be merging this commit for sure.
|
@Thomas-de-Bock, first of all, this PR was sorted better in PR #4 (step by step), so i would like use to take there, not here. this PR I will close after we finish discussion. Regarding this commit comment:
Regarding commit #5 comment: |
|
I suggest you merge this PR and keep split function for another PR (create ISSUE for that, so whoever wants can do, not delaying any PR for that), because this PR is big and changes in many places, so it will be hard to keep up to date, and hard for other developers to restart again from it if you delay it. |
reordered some structs and functions to mach the order of enum CON_TOKENTYPE