Skip to content

Stabilize Windows trusted signing setup - #84

Merged
badcuban merged 1 commit into
mainfrom
agent/fix-windows-trusted-signing
Jul 23, 2026
Merged

Stabilize Windows trusted signing setup#84
badcuban merged 1 commit into
mainfrom
agent/fix-windows-trusted-signing

Conversation

@badcuban

Copy link
Copy Markdown
Collaborator

What changed

  • pin the Azure TrustedSigning PowerShell module to 0.5.8
  • stage it in a deterministic runner directory
  • export that directory through PSModulePath for electron-builder child processes
  • fail before packaging unless Invoke-TrustedSigning resolves

Why

Nightly release run 29979882247 failed in the Windows installer job after electron-builder installed TrustedSigning in one PowerShell process but could not resolve Invoke-TrustedSigning in the signing process. macOS, Linux, release smoke, and release preparation succeeded.

This preserves mandatory Authenticode signing while removing PowerShell module discovery from the critical packaging path.

Validation

  • vp fmt
  • vp lint
  • vp run typecheck
  • vp run release:smoke
  • git diff --check

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
threadlines Ready Ready Preview, Comment Jul 23, 2026 5:18am

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Jul 23, 2026
@badcuban
badcuban marked this pull request as ready for review July 23, 2026 05:22
@badcuban
badcuban merged commit e193260 into main Jul 23, 2026
13 checks passed
@badcuban
badcuban deleted the agent/fix-windows-trusted-signing branch July 23, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant