Fix browser approval sentence semantics - #92
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
badcuban
marked this pull request as ready for review
July 28, 2026 21:47
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Render browser approval subject and destination as one semantic sentence while retaining subject emphasis and the compact approval-bar layout.
Why
The approval subject and predicate were separate flex children. CSS made them look spaced apart, but DOM text concatenated them (
example.comwants...), causing the new browser assertions—and assistive text consumers—to see a malformed sentence.Impact
Browser navigation approvals now expose readable text for both agent-initiated and page-initiated navigation.
Validation
vp fmtvp lintvp run typecheckvp run @threadlines/web#test:browser AgentActivityLine(8 passed)vp run @threadlines/web#test:browser(27 files / 347 tests passed)