Skip to content

fix where condition priority#58

Merged
m110 merged 1 commit into
ThreeDotsLabs:masterfrom
xiluoduyu:patch-1
May 13, 2026
Merged

fix where condition priority#58
m110 merged 1 commit into
ThreeDotsLabs:masterfrom
xiluoduyu:patch-1

Conversation

@xiluoduyu
Copy link
Copy Markdown
Contributor

When where is "delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL", tasks with NULL delayed_until will be repeatly executed, acked=1 wont work: WHERE acked = false AND delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL

Motivation / Background

Details

Alternative approaches considered (if applicable)

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes.
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.

When where is "delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL",  tasks with NULL delayed_until will be repeatly executed, acked=1 wont work:  WHERE acked = false AND delayed_until <= UTC_TIMESTAMP() OR delayed_until IS NULL
@xiluoduyu
Copy link
Copy Markdown
Contributor Author

@rhhammond @lahabana @nyergler This seems like a obvious issue, hope to be fixed.

@m110
Copy link
Copy Markdown
Member

m110 commented May 13, 2026

Thank you @xiluoduyu!

@m110 m110 merged commit ba82ee1 into ThreeDotsLabs:master May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants