Skip to content

v2.0.0 - #10

Open
TkTech wants to merge 4 commits into
mainfrom
dev
Open

v2.0.0#10
TkTech wants to merge 4 commits into
mainfrom
dev

Conversation

@TkTech

@TkTech TkTech commented Mar 4, 2024

Copy link
Copy Markdown
Owner
  • Full typing
  • Isolated heimdall-specific changes as much as possible on a namespace on the task, to minimize conflicts with other Task extensions
  • Early & Late locking, allowing you to control if locks are taken at apply_async() or at the time the task is run, or both. Allows locking when not using apply_async/delay, such as when using send_task().
  • Re-implemented rate-limiting
  • Tracing
  • Minimal, better-suited lock implementation instead of using the one from redis-py. Removed any possibility of blocking, which is an anti-pattern in docker.
  • Allow auto-retry on lock conflicts at call time.
  • Code linting

@TkTech TkTech self-assigned this Mar 4, 2024
@TkTech
TkTech requested review from dominicplouffe and mlepine March 4, 2024 18:18
@codecov

codecov Bot commented Dec 10, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.91620% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.62%. Comparing base (43727fa) to head (c32d926).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
celery_heimdall/task.py 90.81% 9 Missing ⚠️
celery_heimdall/config.py 0.00% 8 Missing ⚠️
celery_heimdall/lock.py 73.07% 7 Missing ⚠️
celery_heimdall/rate.py 93.18% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #10       +/-   ##
===========================================
+ Coverage   58.74%   77.62%   +18.88%     
===========================================
  Files           7        6        -1     
  Lines         286      219       -67     
===========================================
+ Hits          168      170        +2     
+ Misses        118       49       -69     
Flag Coverage Δ
unittests 77.62% <84.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TkTech TkTech mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants