Bad rsv 4 on android

[zhoulifu]

Hello, our team using this library for connecting websocket server on Android platform,
sometimes, there are 'bad rsv 4' errors occurred. Seems same problem with #430.

04-27 14:26:09.960 I/System.out( 1564): D/WebsocketChannel: 000000	48 54 54 50 2f 31 2e 31 20 31 30 31 20 53 77 69 74 63  HTTP/1.1 101 Switc
04-27 14:26:09.960 D/WebSocketChannel( 1564): onError:org.java_websocket.exceptions.InvalidFrameException: bad rsv 4

The debug log above shows the WebSocketImpl treat the handshake response as normal websocket frame and decode it, then throw an InvalidFrameException.

Our client tries to reconnect to server endlessly when it is in condition of unstable network environment.
So is it possible that method org.java_websocket.WebSocketImpl#decode was invoked after WebSocketClient closed in some extreme cases?

[marci4]

Hello @zhoulifu
what do you mean with bad?

Greetings
marci4

[zhoulifu]

@marci4 Sorry i just double click the Enter by mistake :(

[marci4]

Hello @zhoulifu,

no problem. Just was thinking wtf :D

Are you using the latest version 1.3.3?

If so, could you please provide an example application for me,, because right now I cannot reproduce this issue on my test enviroment.

Greetings
marci4

[zhoulifu]

Yes we are using java-websocket-1.3.3.
I'm afraid I can't provide the apk :D, furthermore, it doesn't hannped 100% in our test env :(

But, i'll try may best to produce this issue manually

[marci4]

Hello @zhoulifu

could you please activate the debug printouts with
WebSocketImpl.DEBUG = true;

Could you tell me something about the client you use to connect to the server?

Greetings
marci4

[zhoulifu]

Yes, WebSocketImpl.DEBUG is enabled, and I added some statements in source code

 System.out.println("D/WebSocketChannel: Impl ready state " + readystate);
 System.out.println("D/WebSocketChannel: " + Hexdump.format(socketBuffer.array(), socketBuffer.position(), socketBuffer.remaining()));

here was what I got

04-27 15:40:52.940 I/System.out( 1548): D/WebSocketChannel: Impl ready state CLOSING
04-27 15:40:52.940 I/System.out( 1548): D/WebSocketChannel: 000000    48 54 54 50 2f 31 2e 31 20 31 30 31 20 53 77 69 74 63  HTTP/1.1 101 Switc
04-27 15:40:52.940 D/WebSocketChannel( 1548): onError:org.java_websocket.exceptions.InvalidFrameException: bad rsv 4

It seems that my conjecture was confirmed.

Our client runs as an android system service, it invoke the async method connect() and close(), I think it's the reason of this issue, because the stupid client would invoke close() after connect() was invoked immediately and over and over again in some cases :(

I'm still trying to reproduce this issue, wait for my good news ;D

[marci4]

Hello @zhoulifu,

so as I understand you correctly you use the client provided by this lib.

Could you then try if connectBlocking() and closeBlocking() "fixes" the issue?

Just a heads up, I am going on a little trip for a few days later today. Won't be able to reply then.

Greetings
marci4

[zhoulifu]

It seems those blocking methods are helpful, it works fine so far.
Thanks for your advice, and have a nice trip! :)

[zhoulifu]

Hello @marci4 , please checkout this, it could produce this problem on my computer.

ENV:
Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz
Ubuntu 14.04.5 LTS
Linux 4.4.0-75-generic
Java 1.8.0_101 HotSpot(TM) 64-Bit (build 25.101-b13)

Thanks :)