OnClose is not called when client disconnect

[kunluo2019]

We just upgraded to the latest version. And I noticed that if client process is killed, On server side, onClose is not called. Instead after 30 seconds or so (related to default value in setConnectionLostTimeout), onClose is then called.

Because we were using a old version before, we know, in old version, if we kill the client process, server side, onClose is immediately get called.

Now, it does not do that.

I searched your bug report and found that bug #886 also described the similar situation.

Is this intented change? or there is way for server side to immediately know client socket disconnection?

[marci4]

Hello @kunluo2019,

no there were no (intentional) changes to that behaviour.

What two versions are you comparing?
Could you provide an example code?

Best regards,
Marcel

[kunluo2019]

The issue can be reproduced by compiling sample ChatServer and ChatClient program with old/new websocket library.

After ChatClient is connected to ChatServer

In old version, if I kill ChatClient, ChatServer will immediately printout "has left the room!" message.

In new version, ChatServer won't print that message until the timeOut has reached (setConnectionLostTimeout(100) for 100 seconds in ChatServer code).

If you can tell me how to print the version info from the websocket.jar file, I can provide you corresponding old version number.

The new version is latest 1.4.0.

thanks

[marci4]

What is your old version?

[kunluo2019]

I downloaded around Jan 2018, so it should be between 1.3.7 and 1.3.8.

I still have the corresponding source code.

Does the source code have embedded version number? If so, I can find out.

[marci4]

Pom.xml should contain the version.

Best regards,
Marcel

[kunluo2019]

1.3.8

thanks

[marci4]

No I was not able to find any change that jump out.

Could you please provide a unit test which shows the issue?

Thank you!

Best regards,
Marcel

[kunluo2019]

If you just compile the sample ChatServer and ChatClient that are in examples directory as part of Java-WebSocket, run it, you will see the issue.

In the latest version, if you kill ChatClient, ChatServer will not print "has left the room!" until 100 second timeout has reached.

If you need me to provide the old version, I can upload it for you.

thanks

[maiph]

I was able to reproduce it.

1. Start the CharServer
2. Start 2 ChatClient
3. Press connect on both clients
4. Kill one of the ChatClient
5. The message "has left the room" takes a while to show

I didn't test an older version, only the current version on master 1.4.1-SNAPSHOT

Edit: Just confirmed v1.3.7 doesn't have this problem.