Skip to content

Improve code quality#1072

Merged
marci4 merged 2 commits into
TooTallNate:masterfrom
marci4:ImproveCodeQuality
Jan 7, 2021
Merged

Improve code quality#1072
marci4 merged 2 commits into
TooTallNate:masterfrom
marci4:ImproveCodeQuality

Conversation

@marci4
Copy link
Copy Markdown
Collaborator

@marci4 marci4 commented Sep 20, 2020

Description

This PR fixes issues found by SonarQube

Motivation and Context

Ongoing move to improve code quality

How Has This Been Tested?

Automatic tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Reduce complexity
Fix broken test
@marci4 marci4 marked this pull request as ready for review September 26, 2020 16:17
@marci4 marci4 merged commit 0f0c9a9 into TooTallNate:master Jan 7, 2021
@marci4 marci4 deleted the ImproveCodeQuality branch January 7, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant