Refactoring and improved onClose behaviour#578
Merged
Conversation
-A Getter/Setter is now used for ReadyState -Invalid UTF-8 messages which cause onClose will not have a null reason any more
TooTallNate#577 Client will delay closing the socket until there was an interrupt which normally terminates the WebsocketWriteThread and causes all remaining message to be pushed out (testsuite fails on random test cases, which is probably caused by a high load and is not representive for a real usage scenario)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring in WebSocketImpl so the getter/setter for readyState are now used
onClose will not have null as a reason any more for no valid utf8-strings
Related Issue
#577
Motivation and Context
Bugfix and code cleanups
How Has This Been Tested?
Test suite
Types of changes
Checklist: