Skip to content

Added a broadcast method for ByteBuffers #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marci4 merged 3 commits into from
May 27, 2018
Merged

Added a broadcast method for ByteBuffers #712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab9e858
Added WebSocketServer.broadcast methods for ByteBuffers
PhilipRoman May 25, 2018
135b3c6
Added documentation for new broadcast methods
PhilipRoman May 25, 2018
c074a94
Removed duplicated code from broadcast methods
PhilipRoman May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/main/java/org/java_websocket/server/WebSocketServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,23 +812,42 @@ public void broadcast(byte[] data) {
broadcast( data, connections );
}

/**
* Send a ByteBuffer to all connected endpoints
* @param data the data to send to the endpoints
*/
public void broadcast(ByteBuffer data) {
broadcast(data, connections);
}

/**
* Send a byte array to a specific collection of websocket connections
* @param data the data to send to the endpoints
* @param clients a collection of endpoints to whom the text has to be send
*/
public void broadcast(byte[] data, Collection<WebSocket> clients) {
if (data == null || clients == null) {
throw new IllegalArgumentException();
}
broadcast(ByteBuffer.wrap(data), clients);
}

/**
* Send a ByteBuffer to a specific collection of websocket connections
* @param data the data to send to the endpoints
* @param clients a collection of endpoints to whom the text has to be send
*/
public void broadcast(ByteBuffer data, Collection<WebSocket> clients) {
if (data == null || clients == null) {
throw new IllegalArgumentException();
}
Map<Draft, List<Framedata>> draftFrames = new HashMap<Draft, List<Framedata>>();
ByteBuffer byteBufferData = ByteBuffer.wrap( data );
synchronized( clients ) {
for( WebSocket client : clients ) {
if( client != null ) {
Draft draft = client.getDraft();
if( !draftFrames.containsKey( draft ) ) {
List<Framedata> frames = draft.createFrames( byteBufferData, false );
List<Framedata> frames = draft.createFrames( data, false );
draftFrames.put( draft, frames );
}
try {
Expand Down