WebSocketServer code quality#789
Merged
Merged
Conversation
Reduce complexity for WebSocketServer
For WebSocketFactory and Compression Extension
Collaborator
Author
|
@PhilipRoman Conflict is not relevant FYI |
PhilipRoman
approved these changes
Oct 22, 2018
Collaborator
PhilipRoman
left a comment
PhilipRoman
left a comment
There was a problem hiding this comment.
Wow this is a lot easier to read now! 👍
PhilipRoman
approved these changes
Oct 22, 2018
Collaborator
PhilipRoman
left a comment
PhilipRoman
left a comment
There was a problem hiding this comment.
Wow this is a lot easier to read now! 👍
Collaborator
|
GitHub is not letting me "review" at the moment so I'm leaving this here. The changes are awesome! I didn't check all the tests but the ones I checked are good. 👍 |
1 similar comment
Collaborator
|
GitHub is not letting me "review" at the moment so I'm leaving this here. The changes are awesome! I didn't check all the tests but the ones I checked are good. 👍 |
PhilipRoman
approved these changes
Oct 22, 2018
Collaborator
PhilipRoman
left a comment
PhilipRoman
left a comment
There was a problem hiding this comment.
Wow this is a lot easier to read now! 👍
Collaborator
|
😆 I did not expect that to happen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring as part of improving the code quality
Related Issue
Part of #749
Motivation and Context
Code quality helps fixing issues!
How Has This Been Tested?
All tests pass
Types of changes
Checklist: