Skip to content

Move the startup of the WebSocketWorker inside of run() #856

Merged
marci4 merged 1 commit into
TooTallNate:masterfrom
marci4:Issue855
Feb 11, 2019
Merged

Move the startup of the WebSocketWorker inside of run() #856
marci4 merged 1 commit into
TooTallNate:masterfrom
marci4:Issue855

Conversation

@marci4
Copy link
Copy Markdown
Collaborator

@marci4 marci4 commented Feb 11, 2019

Description

Move the startup of the WebSocketWorker inside of the run() method

Related Issue

Fixes #855

Motivation and Context

Bug found in regression test

How Has This Been Tested?

Additional test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Move the startup of the WebSocketWorker inside of the run() method
@marci4 marci4 added this to the Release 1.4.0 milestone Feb 11, 2019
@marci4 marci4 merged commit 6aa3b1f into TooTallNate:master Feb 11, 2019
@marci4 marci4 deleted the Issue855 branch February 11, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocketServer cannot be started without .start()

1 participant