fix when proxy tunneling failed (IOException is hidden) JDK-8173

[PearSlice]

Handle IOException when proxy auth fails

Description

When using an authenticated proxy to connect to a Websocket and providing wrong credentials the error is hidden.
This fix allows to have a better view on the root exception.

Related Issue

Fixes #905

Motivation and Context

This allows to see exception
Unable to tunnel through proxy. Proxy returns "HTTP/1.1 407 Proxy Auth Required"
instead of having java.lang.InternalError: Should not reach here masking it.

How Has This Been Tested?

By providing wrong/no credentials to our squid proxy in prod env
By providing wrong/no credentials to a local cntlm proxy in dev env

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[marci4]

Hello @PearSlice,

could you please open a normal issue as well where you can describe the problem a bit more into detail (and maybe some steps to repeat etc etc) so other people understand the context.

Thank you!

Best regards,
Marcel

[PearSlice]

Hi,

I created the issue #905 and updated the pull request accordingly.

Best Regards,

Pascal

[marci4]

@PhilipRoman if you have the time, could you maybe do a review please? Thanks

[marci4]

@PhilipRoman you're happy with the PR? (I'm sorry to bother you again)

[PhilipRoman]

Yes, seems like a harmless fix. I couldn't test it though.