Align notification next-step taxonomy - #129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 1 hour, 47 minutes, and 32 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds Changesnext_step Alert Kind
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/multiplexer/runtime-state.ts (1)
148-156: 💤 Low valueConsider adding a clarifying comment about the dedupeKey prefix.
The dedupeKey uses
"idle-needs-input:${session.id}"while the alert kind is now"next_step". This appears intentional for maintaining deduplication during the migration, but a brief comment would help future maintainers understand why the prefix doesn't match the kind.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/multiplexer/runtime-state.ts` around lines 148 - 156, Add a clarifying comment in the publishAlert call that explains why the dedupeKey prefix "idle-needs-input" differs from the alert kind "next_step". The comment should note that this prefix choice is intentional for maintaining deduplication consistency during the migration and help future maintainers understand that this mismatch is not a mistake. Place the comment above the dedupeKey line to make it clear this design choice was deliberate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/multiplexer/runtime-state.ts`:
- Around line 148-156: Add a clarifying comment in the publishAlert call that
explains why the dedupeKey prefix "idle-needs-input" differs from the alert kind
"next_step". The comment should note that this prefix choice is intentional for
maintaining deduplication consistency during the migration and help future
maintainers understand that this mismatch is not a mistake. Place the comment
above the dedupeKey line to make it clear this design choice was deliberate.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c17cebf7-0b49-44df-adb0-f475bf8e04a0
📒 Files selected for processing (13)
app/lib/events.tsapp/lib/notification-policy.test.tsapp/lib/notification-policy.tssrc/alert-display.test.tssrc/alert-display.tssrc/main.tssrc/metadata-server.tssrc/multiplexer/index.tssrc/multiplexer/runtime-state.test.tssrc/multiplexer/runtime-state.tssrc/notify.test.tssrc/notify.tssrc/project-events.ts
Summary
next_stepalert kind for idle turn-end notificationsVerification
Summary by CodeRabbit