Skip to content

Remove aimux-dev workflow#201

Merged
TraderSamwise merged 3 commits into
masterfrom
chore/tui-next-33
Jun 20, 2026
Merged

Remove aimux-dev workflow#201
TraderSamwise merged 3 commits into
masterfrom
chore/tui-next-33

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the aimux-dev CLI entry and old dev-lane targeting logic
  • retarget local app/dev scripts to the single installed aimux runtime on port 43190
  • update runtime docs and test fixtures so aimux-dev / 43191 no longer appear as a supported lane

Verification

  • yarn typecheck
  • yarn lint
  • yarn vitest
  • yarn build
  • yarn --cwd app typecheck
  • yarn --cwd app lint (existing warnings only)
  • yarn --cwd app test

Summary by CodeRabbit

Release Notes

  • New Features

    • Dashboard hotkey (Ctrl+A m) for meta dashboard access
    • Configurable Exposé initial scope (worktree, project, or global)
  • Improvements

    • Streamlined local development workflow with single consolidated runtime installation
    • Standardized daemon port to 43190 for consistency
  • Documentation

    • Updated development and deployment guides to reflect simplified setup workflow

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 20, 2026 2:08pm

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Removes the aimux-dev binary, separate runtime lane (~/.aimux-dev, port 43191), and all associated dual-lane logic. Consolidates to a single aimux runtime on port 43190. Replaces ExposeConfig.forceGlobalScope: boolean with initialScope: "worktree" | "project" | "global". Simplifies isDevelopmentRuntime() to check only AIMUX_ENV, and resolveDashboardReloadCommand() to always return "aimux".

Changes

Remove aimux-dev Lane; Add expose.initialScope

Layer / File(s) Summary
ExposeConfig.initialScope contract and scope resolution
src/config.ts, src/tmux/expose-model.ts, src/tmux/expose-model.test.ts, src/config.test.ts
ExposeConfig drops forceGlobalScope and adds initialScope: "worktree" | "project" | "global"; DEFAULT_CONFIG sets initialScope: "worktree"; initialExposeScope() branches on config.expose.initialScope and removes calls to the now-deleted resolveExposeScope/listExposeAgentItems; tests rewritten for the new shape.
Remove aimux-dev binary and simplify launcher-env
bin/aimux-dev, package.json, src/launcher-env.ts, src/launcher-env.test.ts, scripts/dev-lanes/openrig-runtime-core.sh
bin/aimux-dev removed; package.json drops the aimux-dev bin entry and rewires dev:gui:*/dev:daemon scripts to aimux daemon ensure/restart; prepareDevCliEnv removed from launcher-env.ts; prepareStableCliEnv simplified to fill blank env vars with production defaults; openrig-runtime-core.sh switches from bin/aimux-dev to bin/aimux.
isDevelopmentRuntime simplification and port 43190 consolidation
src/connection-targets.ts, src/connection-targets.test.ts, src/project-takeover.ts, src/project-takeover.test.ts, app/package.json, app/.env.example, app/lib/connection-targets.test.ts, src/local-ui-server.test.ts, src/daemon.test.ts, src/runtime-coherence.test.ts
isDevelopmentRuntime() narrowed to AIMUX_ENV === "development" only, dropping home/port inference; knownOwners() removes the ~/.aimux-dev entry; all port references updated from 43191 to 43190 across app scripts, .env.example, and tests.
Dashboard reload and tmux binding cleanup
src/multiplexer/dashboard-control.ts, src/multiplexer/dashboard-control.test.ts, src/tmux/runtime-manager.test.ts, src/tmux/control-script.test.ts
resolveDashboardReloadCommand() drops conditional entrypoint/env logic and always returns "aimux"; dashboard-control tests updated; tmux runtime-manager and control-script tests change --aimux-home fixture from .aimux-dev to .aimux-custom.
Docs: single-lane runtime, initialScope, port 43190
AGENTS.md, README.md, docs/dev-runtime.md, docs/current-architecture.md, docs/deployment.md
All documentation updated to describe the single aimux lane on port 43190, remove aimux-dev references, add local release asset install workflow, document cross-project terminal surface ownership rules, add Ctrl+A m hotkey, and reference expose.initialScope.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • TraderSamwise/aimux#9: Added bin/aimux-dev, ~/.aimux-dev, and port 43191 — the exact binary and lane that this PR removes.
  • TraderSamwise/aimux#122: Introduced expose.forceGlobalScope plus resolveExposeScope/listExposeAgentItems, which this PR replaces with expose.initialScope and updated scope-derivation logic.
  • TraderSamwise/aimux#179: Added/expanded resolveDashboardReloadCommand() to select aimux vs aimux-dev, which this PR collapses to always return "aimux".

Poem

🐇 One lane to run them all, no more dev twin in sight,
The aimux-dev bin has hopped away into the night.
initialScope replaces the old boolean flag,
Port 43190 waves a triumphant stag.
Now restart the daemon and let the bundle flow —
One rabbit, one runtime, one beautiful aimux show! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove aimux-dev workflow' accurately summarizes the main change: elimination of the separate aimux-dev CLI entry and development runtime lane in favor of a single installed aimux runtime.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tui-next-33

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

app/lib/connection-targets.test.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/config.ts`:
- Around line 56-58: The ExposeConfig interface has changed from boolean
forceGlobalScope to string union initialScope, but no migration logic exists for
existing user configs. Add migration code (either in the config loading function
or as a separate migration utility) that detects the legacy forceGlobalScope key
in user configs and converts it to the new initialScope format: map boolean true
to "global" and false or missing values to "worktree". This ensures users
upgrading from the old config format retain their previous preferences instead
of losing them silently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5b6bbb4-6564-4e93-af8c-1a699221c8bf

📥 Commits

Reviewing files that changed from the base of the PR and between 76b16ed and 86973ec.

📒 Files selected for processing (28)
  • AGENTS.md
  • README.md
  • app/.env.example
  • app/lib/connection-targets.test.ts
  • app/package.json
  • bin/aimux-dev
  • docs/current-architecture.md
  • docs/deployment.md
  • docs/dev-runtime.md
  • package.json
  • scripts/dev-lanes/openrig-runtime-core.sh
  • src/config.test.ts
  • src/config.ts
  • src/connection-targets.test.ts
  • src/connection-targets.ts
  • src/daemon.test.ts
  • src/launcher-env.test.ts
  • src/launcher-env.ts
  • src/local-ui-server.test.ts
  • src/multiplexer/dashboard-control.test.ts
  • src/multiplexer/dashboard-control.ts
  • src/project-takeover.test.ts
  • src/project-takeover.ts
  • src/runtime-coherence.test.ts
  • src/tmux/control-script.test.ts
  • src/tmux/expose-model.test.ts
  • src/tmux/expose-model.ts
  • src/tmux/runtime-manager.test.ts
💤 Files with no reviewable changes (1)
  • bin/aimux-dev

Comment thread src/config.ts
@TraderSamwise
TraderSamwise merged commit 178e7a1 into master Jun 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant