Skip to content

Remove vestigial notification panel - #209

Merged
TraderSamwise merged 1 commit into
masterfrom
chore/tui-next-41
Jun 20, 2026
Merged

Remove vestigial notification panel#209
TraderSamwise merged 1 commit into
masterfrom
chore/tui-next-41

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the old notification-panel overlay, routing, adapter methods, and event-stream refresh hook
  • delete the local production Coordination builder so the TUI only applies service-shaped Coordination payloads
  • update dashboard visible labels from workflow wording to Coordination wording

Verification

  • yarn vitest src/multiplexer/notifications.test.ts src/multiplexer/project-event-stream.test.ts src/multiplexer/dashboard-view-methods.test.ts src/tui/screens/dashboard-renderers.test.ts
  • yarn typecheck
  • yarn lint
  • yarn build
  • yarn vitest
  • pre-push hook: yarn typecheck && yarn lint && yarn test

Summary by CodeRabbit

Release Notes

  • UI Changes

    • Dashboard activity status labels updated from "Workflow" to "Coordination" terminology in activity chips and agent details panels
  • Removed Features

    • Notification panel overlay has been removed; notification management is now handled through the coordination system

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 20, 2026 9:24pm

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed671484-cf9f-4b6a-a48f-3c8de9d9eae5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR removes the "notification-panel" overlay kind, NotificationPanelState interface, and all associated render/open/close/key-handle functions. Notification state is now populated exclusively via a service-driven refreshCoordinationFromService path. Dashboard wiring, event stream triggers, UI activity chip labels, and tests are updated to match.

Changes

Notification Panel Removal and Coordination Refresh

Layer / File(s) Summary
Type and state contract removals
src/dashboard/state.ts, src/multiplexer/index.ts
"notification-panel" removed from DashboardOverlayKind; NotificationPanelState interface and notificationPanelState field removed from Multiplexer.
notifications.ts: remove panel exports, promote coordination refresh
src/multiplexer/notifications.ts
Imports reorganized, CoordinationPayload defined earlier with updated docs; all six notification-panel exported functions removed; module now centers on refreshCoordinationFromService which validates service payload before applying via applyCoordinationModel, returning false on failure.
Remove notification panel overlay renderer
src/tui/screens/overlay-renderers.ts
Theme imports narrowed (drops modalBand, padVisible, statusDot); buildNotificationPanelOverlayOutput and renderNotificationPanel exports deleted.
Dashboard control, view, and actions wiring
src/multiplexer/dashboard-control.ts, src/multiplexer/dashboard-view-methods.ts, src/multiplexer/dashboard-actions-methods.ts, src/multiplexer/project-event-stream.ts
"notification-panel" key-handling and overlay-output branches removed from dashboard-control.ts; notification-panel wrapper methods removed and syncTuiNotificationContext hardcoded to false in dashboard-view-methods.ts; action method renamed from refreshNotificationPanelFromService to refreshCoordinationFromService; event-stream swaps notification-panel conditional refresh for a graveyard-screen conditional.
UI label rename: Workflow → Coordination
src/tui/screens/dashboard-renderers.ts
Three session activity chip texts and one details-panel key label changed from "workflow …" / "Workflow" to "coordination …" / "Coordination".
Test suite: switch to applyServiceLikeCoordinationPayload
src/multiplexer/notifications.test.ts
Imports updated; new applyServiceLikeCoordinationPayload helper introduced; all refreshNotificationEntries(host) calls across six test scenarios replaced with this helper.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • TraderSamwise/aimux#136: Rewrites the notification panel overlay in src/tui/screens/overlay-renderers.ts for a new design language — this PR deletes that same overlay entirely.
  • TraderSamwise/aimux#171: Adds the coordination model and rewires refreshNotificationEntries + NotificationRowMeta that this PR subsequently removes from src/multiplexer/notifications.ts.
  • TraderSamwise/aimux#178: Introduces the coordination refactor and /coordination-worklist API work, directly upstream of the refreshCoordinationFromService path this PR promotes as the sole entry point.

Poem

🐇 Hop hop, the panel has gone away,
No notification drawer to display!
Service-driven coordination's the route,
Old "workflow" chips now shout "coordination" out.
Cleaner code under this bunny's paws today! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main focus of the changeset—removing notification panel functionality across multiple files and modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tui-next-41

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise
TraderSamwise merged commit 285a5b0 into master Jun 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant