Tighten TUI API control paths - #244
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 29 minutes and 58 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughRemoves the Changestmux: Statusline Resolver Removal and Metadata-Only Navigation
Multiplexer: Thread Workflow Deduplication, Mark-seen Fix, and API Route Constant
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/tmux-control.sh (1)
645-648: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winDefer worktree filtering until after
teamresolution.Line 645 filters candidates by
worktreePathbefore theteambranch. That can drop a valid parent/teammate when team members have different worktrees, and Line 800 no longer has the statusline resolver as a fallback. Resolveteamfrom the full metadata set, then apply worktree scoping only fornext|prev|attention|window.🐛 Proposed direction
-items = [item for item in items if item.get("alive") or item.get("windowId") == current_window_id] +items = [item for item in items if item.get("alive") or item.get("windowId") == current_window_id] +current = next((item for item in items if item.get("windowId") == current_window_id), None) + +if action != "team": + if current_worktree: + items = [item for item in items if item.get("worktreePath") == current_worktree] + else: + items = [item for item in items if is_same_or_child_path(current_path, item.get("worktreePath") or "")] -log("items=" + repr([ +log("items=" + repr([ f"{item.get('windowId')}:{item.get('sessionId')}:{item.get('kind')}:{(item.get('team') or {}).get('parentSessionId') or '-'}:{item.get('statusText') or '-'}:{'live' if item.get('alive') else 'dead'}" for item in items ])) ... -current = next((item for item in items if item.get("windowId") == current_window_id), None) if action == "team":As per coding guidelines, “For live-pane prefix shortcuts like
ctrl-a n/p, treat the tmux control path as the default source of truth.”Also applies to: 794-800
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/tmux-control.sh` around lines 645 - 648, The candidate filtering in the tmux control flow is happening too early, before `team` is resolved, which can remove valid teammates/parents and break the statusline resolver fallback. Update the logic around the metadata selection so `team` is computed from the full candidate set first, then apply `worktreePath` scoping only for the `next`, `prev`, `attention`, and `window` paths in the tmux control handling. Use the existing `current_worktree`, `current_path`, and `is_same_or_child_path` logic to locate the relevant selection code and keep the prefix shortcut path as the default source of truth.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/multiplexer/coordination.ts`:
- Around line 202-204: The `mutateDashboardApi` call in `coordination.ts` is
using the wrong payload field for `PROJECT_API_ROUTES.threads.markSeen`; update
the body to match the shared `/threads/mark-seen` contract used by
`src/main.ts`, replacing the `sessionId` field with `session` in this branch.
Keep the fix localized to the mark-seen call so the dashboard path sends the
same payload shape as the shared API.
---
Outside diff comments:
In `@scripts/tmux-control.sh`:
- Around line 645-648: The candidate filtering in the tmux control flow is
happening too early, before `team` is resolved, which can remove valid
teammates/parents and break the statusline resolver fallback. Update the logic
around the metadata selection so `team` is computed from the full candidate set
first, then apply `worktreePath` scoping only for the `next`, `prev`,
`attention`, and `window` paths in the tmux control handling. Use the existing
`current_worktree`, `current_path`, and `is_same_or_child_path` logic to locate
the relevant selection code and keep the prefix shortcut path as the default
source of truth.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a5a1c46-567a-4579-86c5-6217ad7140bd
📒 Files selected for processing (7)
scripts/tmux-control.shsrc/coordination-model.tssrc/multiplexer/coordination.tssrc/multiplexer/dashboard-model.tssrc/multiplexer/notifications.test.tssrc/multiplexer/subscreens.test.tssrc/tmux/control-script.test.ts
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Fixed the outside-diff review note in edd8096: tmux team navigation now resolves against the full live metadata set before same-worktree filtering is applied to ordinary next/prev/attention navigation. Added a regression covering cross-worktree teammate jumps. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Summary
Verification
Summary by CodeRabbit
New Features
Bug Fixes